Source/core/accessibility/AXMenuListPopup.cpp - Issue 192413002: Use new is*Element() helper functions in accessibility code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXMenuListPopup.cpp

Issue 192413002: Use new is*Element() helper functions in accessibility code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AXMenuListPopup.cpp

diff --git a/Source/core/accessibility/AXMenuListPopup.cpp b/Source/core/accessibility/AXMenuListPopup.cpp

index 145792aa05ffb568888c281b1f3d35a92da1811d..b5641a5d497bb35b50e7137526c939098f7c2a75 100644

--- a/Source/core/accessibility/AXMenuListPopup.cpp

+++ b/Source/core/accessibility/AXMenuListPopup.cpp

@@ -66,7 +66,8 @@ bool AXMenuListPopup::computeAccessibilityIsIgnored() const

AXMenuListOption* AXMenuListPopup::menuListOptionAXObject(HTMLElement* element) const

{

- if (!element->hasTagName(optionTag))

+ ASSERT(element);

+ if (!isHTMLOptionElement(*element))

return 0;

AXObject* object = document()->axObjectCache()->getOrCreate(MenuListOptionRole);