Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1924093005: [ignition] Reactivate check for jumps to unbound targets. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Reactivate check for jumps to unbound targets. - Move the check from the BytecodeArrayBuilder destructor, which doesn't get called, to the ToBytecodeArray function. - Remove the now empty destructor. - For generators, bind unused resume point labels somewhere. R=rmcilroy@chromium.org BUG= Committed: https://crrev.com/5595d3579cbc04782c6e09078e22982bd932ac42 Cr-Commit-Position: refs/heads/master@{#35862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/interpreter/bytecode-array-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 7 months ago (2016-04-28 11:59:25 UTC) #1
rmcilroy
LGTM, thanks!
4 years, 7 months ago (2016-04-28 12:26:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924093005/1
4 years, 7 months ago (2016-04-28 12:27:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 12:59:47 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5595d3579cbc04782c6e09078e22982bd932ac42
Cr-Commit-Position: refs/heads/master@{#35862}

Powered by Google App Engine
This is Rietveld 408576698