Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1924093002:
install-build-deps-android.sh support for Ubuntu Xenial (Closed)
Descriptioninstall-build-deps-android.sh support for Ubuntu Xenial
R=dpranke@chromium.org,pgervais@google.com
BUG=601197
Committed: https://crrev.com/3f67f4af2bb655ce6de7dea2b05210145b682f45
Cr-Commit-Position: refs/heads/master@{#390255}
Patch Set 1 #
Total comments: 2
Patch Set 2 : s/pkgs/java_pkgs/ #Messages
Total messages: 18 (9 generated)
On 2016/04/27 22:06:12, friedman wrote: lgtm
The CQ bit was checked by friedman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924093002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== install-build-deps-android.sh support for Ubuntu Xenial R=pgervais@google.com BUG=601197 ========== to ========== install-build-deps-android.sh support for Ubuntu Xenial R=dpranke@chromium.org,pgervais@google.com BUG=601197 ==========
friedman@google.com changed reviewers: + dpranke@google.com
jbudorick@chromium.org changed reviewers: + jbudorick@chromium.org
lgtm w/ nit https://codereview.chromium.org/1924093002/diff/1/build/install-build-deps-an... File build/install-build-deps-android.sh (right): https://codereview.chromium.org/1924093002/diff/1/build/install-build-deps-an... build/install-build-deps-android.sh:27: pkgs="openjdk-8-jre openjdk-8-jdk" nit: name this something like "java_pkgs" or something more specific than just "pkgs"
https://codereview.chromium.org/1924093002/diff/1/build/install-build-deps-an... File build/install-build-deps-android.sh (right): https://codereview.chromium.org/1924093002/diff/1/build/install-build-deps-an... build/install-build-deps-android.sh:27: pkgs="openjdk-8-jre openjdk-8-jdk" On 2016/04/27 23:30:07, jbudorick wrote: > nit: name this something like "java_pkgs" or something more specific than just > "pkgs" Done.
The CQ bit was checked by friedman@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from pgervais@chromium.org, jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/1924093002/#ps20001 (title: "s/pkgs/java_pkgs/")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924093002/20001
Message was sent while issue was closed.
Description was changed from ========== install-build-deps-android.sh support for Ubuntu Xenial R=dpranke@chromium.org,pgervais@google.com BUG=601197 ========== to ========== install-build-deps-android.sh support for Ubuntu Xenial R=dpranke@chromium.org,pgervais@google.com BUG=601197 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3f67f4af2bb655ce6de7dea2b05210145b682f45 Cr-Commit-Position: refs/heads/master@{#390255}
Message was sent while issue was closed.
Description was changed from ========== install-build-deps-android.sh support for Ubuntu Xenial R=dpranke@chromium.org,pgervais@google.com BUG=601197 ========== to ========== install-build-deps-android.sh support for Ubuntu Xenial R=dpranke@chromium.org,pgervais@google.com BUG=601197 Committed: https://crrev.com/3f67f4af2bb655ce6de7dea2b05210145b682f45 Cr-Commit-Position: refs/heads/master@{#390255} ========== |
