Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1924083004: Add UMA metric for tracking listeners for blocking touch before page finished loading (Closed)

Created:
4 years, 7 months ago by lanwei
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Add UMA metric for tracking listeners for blocking touch before page finished loading In the touch scrolling intervention proposal, rbyers@ proposed that we could treat all touch event listeners as passive until the load event fires. We are adding metrics that record when touchstart or first touchmove events are successfully preventDefaulted() before the load event to measure breakage of event handlers. BUG=601179 Review-Url: https://codereview.chromium.org/1879233005 Cr-Commit-Position: refs/heads/master@{#390257} (cherry picked from commit 0e80d7ffdef2a817d66be17a0e9fe68029f6d8d7) Committed: https://chromium.googlesource.com/chromium/src/+/5a56668d4208b56616f05f8b68097f7ac3aaa702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M third_party/WebKit/Source/core/input/EventHandler.cpp View 2 chunks +15 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lanwei
4 years, 7 months ago (2016-04-29 00:14:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a56668d4208b56616f05f8b68097f7ac3aaa702.

Powered by Google App Engine
This is Rietveld 408576698