third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, fix new test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/ChromeClientImpl.cpp ('K') | « third_party/WebKit/Source/web/tests/ViewportTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index 138c55a338b1be3246d57313f1abcdcdf77e0c94..1e192b9cd497bf972c13c4da80e8f3166bbf0d75 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -119,7 +119,7 @@ public:

{

if (!overrideSettingsFunc)

overrideSettingsFunc = &configureSettings;

- m_helper.initialize(true, 0, &m_mockWebViewClient, overrideSettingsFunc);

+ m_helper.initialize(true, nullptr, &m_mockWebViewClient, nullptr, overrideSettingsFunc);

webViewImpl()->setDefaultPageScaleLimits(1, 4);

}

@@ -127,7 +127,7 @@ public:

{

if (!overrideSettingsFunc)

overrideSettingsFunc = &configureAndroidSettings;

- m_helper.initialize(true, 0, &m_mockWebViewClient, overrideSettingsFunc);

+ m_helper.initialize(true, nullptr, &m_mockWebViewClient, nullptr, overrideSettingsFunc);

webViewImpl()->setDefaultPageScaleLimits(0.25f, 5);

}