third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp - Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, fix new test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/ChromeClientImpl.cpp ('K') | « third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp ('k') | third_party/WebKit/Source/web/tests/RootScrollerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp b/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

index a82e133a74db7c2da87c618205e002b9a3a54d35..b87c75cb52843e0fb2e77f9987f232dd9696b512 100644

--- a/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

+++ b/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp

@@ -108,7 +108,7 @@ protected:

// We need to set deviceSupportsMouse setting to true and page's focus controller to active

// so that FrameView can set the mouse cursor.

- m_webView = m_helper.initialize(false, &m_testFrameClient, nullptr,

+ m_webView = m_helper.initialize(false, &m_testFrameClient, nullptr, nullptr,

[](WebSettings* settings) { settings->setDeviceSupportsMouse(true); });

m_mainFrame = m_webView->mainFrameImpl();

FrameTestHelpers::loadHTMLString(m_mainFrame, kHTMLString, URLTestHelpers::toKURL("http://foobar.com"));