third_party/WebKit/Source/web/PageOverlayTest.cpp - Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PageOverlayTest.cpp

Issue 1924043002: Switch the inheritance of WebViewClient from WebWidgetClient to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, fix new test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/ChromeClientImpl.cpp ('K') | « third_party/WebKit/Source/web/ChromeClientImpl.cpp ('k') | third_party/WebKit/Source/web/WebFrameWidgetImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/PageOverlayTest.cpp

diff --git a/third_party/WebKit/Source/web/PageOverlayTest.cpp b/third_party/WebKit/Source/web/PageOverlayTest.cpp

index bf2036c4ab99ef2eb153bc1fddb5106900cbf14d..b592a509633ea4a62fd2ed5f29b1f2008db703ab 100644

--- a/third_party/WebKit/Source/web/PageOverlayTest.cpp

+++ b/third_party/WebKit/Source/web/PageOverlayTest.cpp

@@ -71,7 +71,7 @@ protected:

void initialize(CompositingMode compositingMode)

{

m_helper.initialize(

- false /* enableJavascript */, nullptr /* webFrameClient */, nullptr /* webViewClient */,

+ false /* enableJavascript */, nullptr /* webFrameClient */, nullptr /* webViewClient */, nullptr /* webWidgetClient */,

compositingMode == AcceleratedCompositing ? enableAcceleratedCompositing : disableAcceleratedCompositing);

webViewImpl()->resize(WebSize(viewportWidth, viewportHeight));

webViewImpl()->updateAllLifecyclePhases();