third_party/WebKit/Source/web/AssociatedURLLoader.cpp - Issue 1923993002: Revert of Remove unnecessary uses of GarbageCollectedFinalized<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/AssociatedURLLoader.cpp

Issue 1923993002: Revert of Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/AssociatedURLLoader.cpp

diff --git a/third_party/WebKit/Source/web/AssociatedURLLoader.cpp b/third_party/WebKit/Source/web/AssociatedURLLoader.cpp

index 2c4d3a3ac0fd9f4b2f429067fd39b6ae0742c24e..32422fdaad299dc0497c6e964a58ea6fab465dc8 100644

--- a/third_party/WebKit/Source/web/AssociatedURLLoader.cpp

+++ b/third_party/WebKit/Source/web/AssociatedURLLoader.cpp

@@ -290,7 +290,7 @@

m_client->didFail(m_loader, m_error);

}

-class AssociatedURLLoader::Observer final : public GarbageCollected<Observer>, public ContextLifecycleObserver {

+class AssociatedURLLoader::Observer final : public GarbageCollectedFinalized<Observer>, public ContextLifecycleObserver {

USING_GARBAGE_COLLECTED_MIXIN(Observer);

public:

Observer(AssociatedURLLoader* parent, Document* document)

« no previous file with comments | « third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp ('k') | no next file » | no next file with comments »