Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: ash/wm/overview/window_selector.cc

Issue 1923983003: Makes WorkspaceLayoutManager use ash/wm/common types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix always-on-top and remove mus changes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overview/window_selector.cc
diff --git a/ash/wm/overview/window_selector.cc b/ash/wm/overview/window_selector.cc
index 04794285a2c59535e05805ece43a4ac379b86049..149699e787effaaba6175cb9a786e6e279e520d8 100644
--- a/ash/wm/overview/window_selector.cc
+++ b/ash/wm/overview/window_selector.cc
@@ -16,8 +16,8 @@
#include "ash/root_window_controller.h"
#include "ash/shell.h"
#include "ash/shell_window_ids.h"
-#include "ash/switchable_windows.h"
#include "ash/wm/aura/wm_window_aura.h"
+#include "ash/wm/common/switchable_windows.h"
#include "ash/wm/common/window_state.h"
#include "ash/wm/mru_window_tracker.h"
#include "ash/wm/overview/window_grid.h"
@@ -270,9 +270,9 @@ void WindowSelector::Init(const WindowList& windows) {
iter != root_windows.end(); iter++) {
// Observed switchable containers for newly created windows on all root
// windows.
- for (size_t i = 0; i < kSwitchableWindowContainerIdsLength; ++i) {
- aura::Window* container = Shell::GetContainer(*iter,
- kSwitchableWindowContainerIds[i]);
+ for (size_t i = 0; i < wm::kSwitchableWindowContainerIdsLength; ++i) {
+ aura::Window* container =
+ Shell::GetContainer(*iter, wm::kSwitchableWindowContainerIds[i]);
container->AddObserver(this);
observed_windows_.insert(container);
}
@@ -486,8 +486,8 @@ void WindowSelector::OnWindowAdded(aura::Window* new_window) {
if (!IsSelectable(new_window))
return;
- for (size_t i = 0; i < kSwitchableWindowContainerIdsLength; ++i) {
- if (new_window->parent()->id() == kSwitchableWindowContainerIds[i] &&
+ for (size_t i = 0; i < wm::kSwitchableWindowContainerIdsLength; ++i) {
+ if (new_window->parent()->id() == wm::kSwitchableWindowContainerIds[i] &&
!::wm::GetTransientParent(new_window)) {
// The new window is in one of the switchable containers, abort overview.
CancelSelection();

Powered by Google App Engine
This is Rietveld 408576698