Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2729)

Unified Diff: ash/wm/common/switchable_windows.cc

Issue 1923983003: Makes WorkspaceLayoutManager use ash/wm/common types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/common/switchable_windows.cc
diff --git a/ash/switchable_windows.cc b/ash/wm/common/switchable_windows.cc
similarity index 52%
rename from ash/switchable_windows.cc
rename to ash/wm/common/switchable_windows.cc
index 72b06bb9ae0e100a7abb7d8cf60edcac409bdd38..081d83684a89fcc234015a3fcfaa9019e55ad741 100644
--- a/ash/switchable_windows.cc
+++ b/ash/wm/common/switchable_windows.cc
@@ -2,31 +2,32 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "ash/switchable_windows.h"
+#include "ash/wm/common/switchable_windows.h"
-#include "ash/shell_window_ids.h"
-#include "ui/aura/window.h"
+#include "ash/wm/common/wm_shell_window_ids.h"
+#include "ash/wm/common/wm_window.h"
namespace ash {
+namespace wm {
const int kSwitchableWindowContainerIds[] = {
- kShellWindowId_DefaultContainer,
sky 2016/04/27 20:48:05 I think this looks better, but I ran 'git cl forma
James Cook 2016/04/27 23:24:24 Yeah. I'm OK with the new formatting, and I'm also
- kShellWindowId_AlwaysOnTopContainer,
- kShellWindowId_DockedContainer,
- kShellWindowId_PanelContainer,
+ kShellWindowId_DefaultContainer, kShellWindowId_AlwaysOnTopContainer,
+ kShellWindowId_DockedContainer, kShellWindowId_PanelContainer,
kShellWindowId_AppListContainer};
const size_t kSwitchableWindowContainerIdsLength =
arraysize(kSwitchableWindowContainerIds);
-bool IsSwitchableContainer(const aura::Window* window) {
+bool IsSwitchableContainer(const wm::WmWindow* window) {
if (!window)
return false;
+ const int shell_window_id = window->GetShellWindowId();
for (size_t i = 0; i < kSwitchableWindowContainerIdsLength; ++i) {
- if (window->id() == kSwitchableWindowContainerIds[i])
+ if (shell_window_id == kSwitchableWindowContainerIds[i])
return true;
}
return false;
}
+} // namespace wm
} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698