Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: ash/wm/mru_window_tracker.cc

Issue 1923983003: Makes WorkspaceLayoutManager use ash/wm/common types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix always-on-top and remove mus changes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/wm/mru_window_tracker.h" 5 #include "ash/wm/mru_window_tracker.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "ash/session/session_state_delegate.h" 9 #include "ash/session/session_state_delegate.h"
10 #include "ash/shell.h" 10 #include "ash/shell.h"
11 #include "ash/shell_window_ids.h" 11 #include "ash/shell_window_ids.h"
12 #include "ash/switchable_windows.h"
13 #include "ash/wm/ash_focus_rules.h" 12 #include "ash/wm/ash_focus_rules.h"
13 #include "ash/wm/aura/wm_window_aura.h"
14 #include "ash/wm/common/switchable_windows.h"
14 #include "ash/wm/common/window_state.h" 15 #include "ash/wm/common/window_state.h"
15 #include "ash/wm/window_util.h" 16 #include "ash/wm/window_util.h"
16 #include "ash/wm/workspace_controller.h" 17 #include "ash/wm/workspace_controller.h"
17 #include "base/bind.h" 18 #include "base/bind.h"
18 #include "ui/aura/window_event_dispatcher.h" 19 #include "ui/aura/window_event_dispatcher.h"
19 #include "ui/events/event.h" 20 #include "ui/events/event.h"
20 #include "ui/events/event_handler.h" 21 #include "ui/events/event_handler.h"
21 #include "ui/wm/public/activation_client.h" 22 #include "ui/wm/public/activation_client.h"
22 23
23 namespace ash { 24 namespace ash {
(...skipping 27 matching lines...) Expand all
51 const std::list<aura::Window*>* mru_windows, 52 const std::list<aura::Window*>* mru_windows,
52 const CanActivateWindowPredicate& should_include_window_predicate) { 53 const CanActivateWindowPredicate& should_include_window_predicate) {
53 MruWindowTracker::WindowList windows; 54 MruWindowTracker::WindowList windows;
54 aura::Window::Windows root_windows = Shell::GetAllRootWindows(); 55 aura::Window::Windows root_windows = Shell::GetAllRootWindows();
55 56
56 aura::Window* active_root = Shell::GetTargetRootWindow(); 57 aura::Window* active_root = Shell::GetTargetRootWindow();
57 for (aura::Window::Windows::const_iterator iter = root_windows.begin(); 58 for (aura::Window::Windows::const_iterator iter = root_windows.begin();
58 iter != root_windows.end(); ++iter) { 59 iter != root_windows.end(); ++iter) {
59 if (*iter == active_root) 60 if (*iter == active_root)
60 continue; 61 continue;
61 for (size_t i = 0; i < kSwitchableWindowContainerIdsLength; ++i) 62 for (size_t i = 0; i < wm::kSwitchableWindowContainerIdsLength; ++i)
62 AddTrackedWindows(*iter, kSwitchableWindowContainerIds[i], &windows); 63 AddTrackedWindows(*iter, wm::kSwitchableWindowContainerIds[i], &windows);
63 } 64 }
64 65
65 // Add windows in the active root windows last so that the topmost window 66 // Add windows in the active root windows last so that the topmost window
66 // in the active root window becomes the front of the list. 67 // in the active root window becomes the front of the list.
67 for (size_t i = 0; i < kSwitchableWindowContainerIdsLength; ++i) 68 for (size_t i = 0; i < wm::kSwitchableWindowContainerIdsLength; ++i)
68 AddTrackedWindows(active_root, kSwitchableWindowContainerIds[i], &windows); 69 AddTrackedWindows(active_root, wm::kSwitchableWindowContainerIds[i],
70 &windows);
69 71
70 // Removes unfocusable windows. 72 // Removes unfocusable windows.
71 std::vector<aura::Window*>::iterator itr = windows.begin(); 73 std::vector<aura::Window*>::iterator itr = windows.begin();
72 while (itr != windows.end()) { 74 while (itr != windows.end()) {
73 if (!should_include_window_predicate.Run(*itr)) 75 if (!should_include_window_predicate.Run(*itr))
74 itr = windows.erase(itr); 76 itr = windows.erase(itr);
75 else 77 else
76 ++itr; 78 ++itr;
77 } 79 }
78 80
79 // Put the windows in the mru_windows list at the head, if it's available. 81 // Put the windows in the mru_windows list at the head, if it's available.
80 if (mru_windows) { 82 if (mru_windows) {
81 // Iterate through the list backwards, so that we can move each window to 83 // Iterate through the list backwards, so that we can move each window to
82 // the front of the windows list as we find them. 84 // the front of the windows list as we find them.
83 for (std::list<aura::Window*>::const_reverse_iterator ix = 85 for (std::list<aura::Window*>::const_reverse_iterator ix =
84 mru_windows->rbegin(); 86 mru_windows->rbegin();
85 ix != mru_windows->rend(); ++ix) { 87 ix != mru_windows->rend(); ++ix) {
86 // Exclude windows in non-switchable containers and those which cannot 88 // Exclude windows in non-switchable containers and those which cannot
87 // be activated. 89 // be activated.
88 if (!IsSwitchableContainer((*ix)->parent()) || 90 if (!wm::IsSwitchableContainer(wm::WmWindowAura::Get((*ix)->parent())) ||
89 !should_include_window_predicate.Run(*ix)) { 91 !should_include_window_predicate.Run(*ix)) {
90 continue; 92 continue;
91 } 93 }
92 94
93 MruWindowTracker::WindowList::iterator window = 95 MruWindowTracker::WindowList::iterator window =
94 std::find(windows.begin(), windows.end(), *ix); 96 std::find(windows.begin(), windows.end(), *ix);
95 if (window != windows.end()) { 97 if (window != windows.end()) {
96 windows.erase(window); 98 windows.erase(window);
97 windows.push_back(*ix); 99 windows.push_back(*ix);
98 } 100 }
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 mru_windows_.remove(window); 191 mru_windows_.remove(window);
190 window->RemoveObserver(this); 192 window->RemoveObserver(this);
191 } 193 }
192 194
193 bool MruWindowTracker::IsWindowConsideredActivateable( 195 bool MruWindowTracker::IsWindowConsideredActivateable(
194 aura::Window* window) const { 196 aura::Window* window) const {
195 return focus_rules_->IsWindowConsideredActivatable(window); 197 return focus_rules_->IsWindowConsideredActivatable(window);
196 } 198 }
197 199
198 } // namespace ash 200 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698