Pubspec-specified analysis configuration (#26359).

Pubspec-specified analysis configuration (#26359).

Provides support for pubspec-specified analysis configurations.

Context: https://github.com/dart-lang/sdk/issues/26359

TODO:
  * docs
  * CLI support

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/870aa5e4f48be9574cd2fbc1dd191f1c91317835

[pquitslund, 2016-04-28 17:12:52]

Description was changed from

==========
Pubspec-specified analysis configuration.

Provides support for pubspec-specified analysis configurations.

Context here:
https://docs.google.com/document/d/1rRlZut75Twl8hJ6529xjGRc12miHFPpQ8gr_oP6J3...

TODO:
  * docs
  * CLI support

BUG=
==========

to

==========
Pubspec-specified analysis configuration (#26359).

Provides support for pubspec-specified analysis configurations.

Context: https://github.com/dart-lang/sdk/issues/26359

TODO:
  * docs
  * CLI support

BUG=
==========

[pquitslund, 2016-04-28 17:12:52]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-04-28 18:05:59]

lgtm

https://codereview.chromium.org/1923973004/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/1923973004/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/context_manager.dart:1267: if (context is!
InternalAnalysisContext) {
While I appreciate the fact that this style removed a level of nesting, making
the code easier to read, it requires an implicit or explicit cast, which is
expensive (and the introduction of another local variable, but that's minor).
I've been removing as many casts as possible, so it would be great if we didn't
add more back in.

[pquitslund, 2016-04-28 18:13:42]

Thanks!

https://codereview.chromium.org/1923973004/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/1923973004/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/context_manager.dart:1267: if (context is!
InternalAnalysisContext) {
On 2016/04/28 18:05:59, Brian Wilkerson wrote:
> While I appreciate the fact that this style removed a level of nesting, making
> the code easier to read, it requires an implicit or explicit cast, which is
> expensive (and the introduction of another local variable, but that's minor).
> I've been removing as many casts as possible, so it would be great if we
didn't
> add more back in.

Done.

[pquitslund, 2016-04-28 20:10:49]

Description was changed from

==========
Pubspec-specified analysis configuration (#26359).

Provides support for pubspec-specified analysis configurations.

Context: https://github.com/dart-lang/sdk/issues/26359

TODO:
  * docs
  * CLI support

BUG=
==========

to

==========
Pubspec-specified analysis configuration (#26359).

Provides support for pubspec-specified analysis configurations.

Context: https://github.com/dart-lang/sdk/issues/26359

TODO:
  * docs
  * CLI support

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/870aa5e4f48be9574cd2fbc1dd191f1c91317835
==========

[pquitslund, 2016-04-28 20:10:51]

Committed patchset #2 (id:20001) manually as
870aa5e4f48be9574cd2fbc1dd191f1c91317835 (presubmit successful).