Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2188)

Unified Diff: components/gcm_driver/gcm_driver.h

Issue 1923953002: Integrate InstanceID with GCM crypto provider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid5default
Patch Set: RunUntilIdle after deleting GCMDriver Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/gcm_driver/gcm_driver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_driver.h
diff --git a/components/gcm_driver/gcm_driver.h b/components/gcm_driver/gcm_driver.h
index f87bc2a3d6ef9b26d5c9bac3704e71a9d7cbbf67..6cf0cdf3e20f442a64072a0167d1181fd47d97b6 100644
--- a/components/gcm_driver/gcm_driver.h
+++ b/components/gcm_driver/gcm_driver.h
@@ -138,7 +138,8 @@ class GCMDriver {
// Get the public encryption key and the authentication secret associated with
// |app_id|. If none have been associated with |app_id| yet, they will be
- // created. The |callback| will be invoked when it is available.
+ // created. The |callback| will be invoked when it is available. Only use with
+ // GCM registrations; use InstanceID::GetEncryptionInfo for InstanceID tokens.
void GetEncryptionInfo(const std::string& app_id,
const GetEncryptionInfoCallback& callback);
@@ -212,8 +213,11 @@ class GCMDriver {
// to send a heartbeat message.
virtual void WakeFromSuspendForHeartbeat(bool wake) = 0;
- // Supports InstanceID handling. Must only be used by the InstanceID system.
+ // These methods must only be used by the InstanceID system.
+ // The InstanceIDHandler provides an implementation for the InstanceID system.
virtual InstanceIDHandler* GetInstanceIDHandlerInternal() = 0;
+ // Allows the InstanceID system to integrate with GCM encryption storage.
+ GCMEncryptionProvider* GetEncryptionProviderInternal();
// Adds or removes a custom client requested heartbeat interval. If multiple
// components set that setting, the lowest setting will be used. If the
« no previous file with comments | « no previous file | components/gcm_driver/gcm_driver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698