Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: components/gcm_driver/instance_id/instance_id_android.cc

Issue 1923953002: Integrate InstanceID with GCM crypto provider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid5default
Patch Set: Fix Android compile Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/instance_id/instance_id_android.cc
diff --git a/components/gcm_driver/instance_id/instance_id_android.cc b/components/gcm_driver/instance_id/instance_id_android.cc
index 40b333041c4ed192a99da514178b6ca67504bc62..64db20b0c862155940377a73dafff1b4346c8e91 100644
--- a/components/gcm_driver/instance_id/instance_id_android.cc
+++ b/components/gcm_driver/instance_id/instance_id_android.cc
@@ -46,12 +46,13 @@ bool InstanceIDAndroid::RegisterJni(JNIEnv* env) {
// static
std::unique_ptr<InstanceID> InstanceID::Create(const std::string& app_id,
- gcm::InstanceIDHandler* unused) {
- return base::WrapUnique(new InstanceIDAndroid(app_id));
+ gcm::GCMDriver* gcm_driver) {
+ return base::WrapUnique(new InstanceIDAndroid(app_id, gcm_driver));
}
-InstanceIDAndroid::InstanceIDAndroid(const std::string& app_id)
- : InstanceID(app_id) {
+InstanceIDAndroid::InstanceIDAndroid(const std::string& app_id,
+ gcm::GCMDriver* gcm_driver)
+ : InstanceID(app_id, gcm_driver) {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(!app_id.empty()) << "Empty app_id is not supported";
@@ -117,9 +118,9 @@ void InstanceIDAndroid::GetToken(
base::android::ToJavaArrayOfStrings(env, options_strings).obj());
}
-void InstanceIDAndroid::DeleteToken(const std::string& authorized_entity,
- const std::string& scope,
- const DeleteTokenCallback& callback) {
+void InstanceIDAndroid::DeleteTokenImpl(const std::string& authorized_entity,
+ const std::string& scope,
+ const DeleteTokenCallback& callback) {
DCHECK(thread_checker_.CalledOnValidThread());
int32_t request_id =
@@ -132,7 +133,7 @@ void InstanceIDAndroid::DeleteToken(const std::string& authorized_entity,
ConvertUTF8ToJavaString(env, scope).obj());
}
-void InstanceIDAndroid::DeleteID(const DeleteIDCallback& callback) {
+void InstanceIDAndroid::DeleteIDImpl(const DeleteIDCallback& callback) {
DCHECK(thread_checker_.CalledOnValidThread());
int32_t request_id = delete_id_callbacks_.Add(new DeleteIDCallback(callback));

Powered by Google App Engine
This is Rietveld 408576698