Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Unified Diff: chrome/browser/chromeos/policy/system_log_uploader.cc

Issue 1923943003: Add logging to remote commands (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused include Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/system_log_uploader.cc
diff --git a/chrome/browser/chromeos/policy/system_log_uploader.cc b/chrome/browser/chromeos/policy/system_log_uploader.cc
index 58e83b5331f572d645fbb6dd9714acad6586381b..4a6240a1c341080fbf4bc0c999359786093ccc60 100644
--- a/chrome/browser/chromeos/policy/system_log_uploader.cc
+++ b/chrome/browser/chromeos/policy/system_log_uploader.cc
@@ -101,6 +101,8 @@ std::unique_ptr<policy::UploadJob> SystemLogDelegate::CreateUploadJob(
g_browser_process->system_request_context();
std::string robot_account_id =
device_oauth2_token_service->GetRobotAccountId();
+
+ LOG(WARNING) << "Creating upload job for system log";
return std::unique_ptr<policy::UploadJob>(new policy::UploadJobImpl(
upload_url, robot_account_id, device_oauth2_token_service,
system_request_context, delegate,
@@ -186,6 +188,7 @@ SystemLogUploader::SystemLogUploader(
SystemLogUploader::~SystemLogUploader() {}
void SystemLogUploader::OnSuccess() {
+ LOG(WARNING) << "Upload successful.";
upload_job_.reset();
last_upload_attempt_ = base::Time::NowFromSystemTime();
retry_count_ = 0;
@@ -203,10 +206,12 @@ void SystemLogUploader::OnFailure(UploadJob::ErrorCode error_code) {
// attempt and schedule the next one using the normal delay. Otherwise, retry
// uploading after kErrorUploadDelayMs milliseconds.
if (retry_count_++ < kMaxNumRetries) {
+ LOG(ERROR) << "Upload failed, retrying later.";
Andrew T Wilson (Slow) 2016/05/04 14:43:23 Log the error code.
Marton Hunyady 2016/05/09 13:48:15 Done.
ScheduleNextSystemLogUpload(
base::TimeDelta::FromMilliseconds(kErrorUploadDelayMs));
} else {
// No more retries.
Andrew T Wilson (Slow) 2016/05/04 14:43:23 Log error code (unless it's logged elsewhere)
Marton Hunyady 2016/05/09 13:48:15 Done.
+ LOG(ERROR) << "Upload failed, no more retries.";
retry_count_ = 0;
ScheduleNextSystemLogUpload(upload_frequency_);
}

Powered by Google App Engine
This is Rietveld 408576698