Add logging to remote commands

chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 35 matching lines @@
 }
 
 bool DeviceCommandRebootJob::IsExpired(base::TimeTicks now) {
   return now > issued_time() + base::TimeDelta::FromMinutes(
                                    kCommandExpirationTimeInMinutes);
 }
 
 void DeviceCommandRebootJob::RunImpl(
     const CallbackWithResult& succeeded_callback,
     const CallbackWithResult& failed_callback) {
+  LOG(WARNING) << "Running reboot command.";
+
   // Determines the time delta between the command having been issued and the
   // boot time of the system.
   const base::TimeDelta uptime = base::SysInfo::Uptime();
   const base::TimeTicks boot_time = base::TimeTicks::Now() - uptime;
   const base::TimeDelta delta = boot_time - issued_time();
   // If the reboot command was issued before the system booted, we inform the
   // server that the reboot succeeded. Otherwise, the reboot must still be
   // performed and we invoke it. |kMinimumUptimeInMinutes| defines a lower limit
   // on the uptime to avoid uninterruptable reboot loops.
   if (delta > base::TimeDelta()) {
+    LOG(WARNING) << "Reboot command already has been executed.";

[Andrew T Wilson (Slow), 2016/05/04 14:43:22]

Change this to something like: "Ignoring reboot command issued before current
boot - delta = " << delta;

[Marton Hunyady, 2016/05/09 13:48:15]

Done.

     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE, base::Bind(succeeded_callback, nullptr));
     return;
   }
 
   const base::TimeDelta kZeroTimeDelta;
-  reboot_timer_.Start(
-      FROM_HERE,
+  base::TimeDelta reboot_delay =
       std::max(base::TimeDelta::FromMinutes(kMinimumUptimeInMinutes) - uptime,
-               kZeroTimeDelta),
-      base::Bind(&DeviceCommandRebootJob::Reboot,
-                 weak_ptr_factory_.GetWeakPtr()));
+               kZeroTimeDelta);
+  if (reboot_delay > kZeroTimeDelta) {
+    LOG(WARNING) << "Rebooting in " << reboot_delay << ".";

[Andrew T Wilson (Slow), 2016/05/04 14:43:22]

Add a unit here, e.g. "Rebooting in 1234 msecs."

[Marton Hunyady, 2016/05/09 13:48:15]

reboot_delay is a base::TimeDelta, so it currently prints something like
"Rebooting in 565.426s."

+  } else {
+    LOG(WARNING) << "Rebooting immediately.";
+  }
+  reboot_timer_.Start(FROM_HERE, reboot_delay,
+                      base::Bind(&DeviceCommandRebootJob::Reboot,
+                                 weak_ptr_factory_.GetWeakPtr()));
 }
 
 void DeviceCommandRebootJob::TerminateImpl() {
   weak_ptr_factory_.InvalidateWeakPtrs();
 }
 
 base::TimeDelta DeviceCommandRebootJob::GetCommmandTimeout() const {
   return base::TimeDelta::FromMinutes(kMinimumUptimeInMinutes);
 }
 
 void DeviceCommandRebootJob::Reboot() const {
   power_manager_client_->RequestRestart();
 }
 
 }  // namespace policy