Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1923943002:
Remove all uses of skia::RefPtr (Closed)
|
Created:
4 years, 7 months ago by tomhudson Modified:
4 years, 6 months ago CC:
chromium-reviews, sadrul, posciak+watch_chromium.org, dshwang, sievers+watch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, piman+watch_chromium.org, kinuko+watch, danakj+watch_chromium.org, rwlbuis, extensions-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, maniscalco+watch-blimp_chromium.org, Rik, jam, Justin Novosad, jbauman+watch_chromium.org, blink-reviews-platform-graphics_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, ozone-reviews_chromium.org, jbroman, feature-media-reviews_chromium.org, krit, mcasas+watch+vc_chromium.org, kalyank, drott+blinkwatch_chromium.org, Stephen Chennney, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, Ian Vollick, tfarina, f(malita), mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, dtrainor+watch-blimp_chromium.org, James Cook, Wez Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove all uses of skia::RefPtr
Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.
We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.
BUG=skia:5077
TBR=jamescook@chromium.org,wez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/8691d7777e2ffbf7ea7ca351acc9dd02ab888d69
Cr-Commit-Position: refs/heads/master@{#398874}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : #Patch Set 4 : #Patch Set 5 : restore unwanted header on windows until typefaces done #Patch Set 6 : rebase et al #Patch Set 7 : free the SkTypefaces #Patch Set 8 : random windows <algorithm> missing? #Patch Set 9 : rebase #Patch Set 10 : fix bad rebase in ppapi? #Patch Set 11 : rebase #Patch Set 12 : fix bad rebase in font_config_ipc_linux #Patch Set 13 : rebase was backwards in header file too #Patch Set 14 : #
Total comments: 1
Patch Set 15 : rebase #
Messages
Total messages: 48 (24 generated)
Description was changed from ========== WIP Remove skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 ========== to ========== WIP Remove skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
The CQ bit was checked by tomhudson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923943002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by tomhudson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923943002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by tomhudson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923943002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
Description was changed from ========== WIP Remove skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Remove skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
The CQ bit was checked by tomhudson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923943002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923943002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
Description was changed from ========== Remove skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Remove all uses of skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
The CQ bit was checked by tomhudson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923943002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923943002/120001
The CQ bit was checked by tomhudson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923943002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923943002/160001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tomhudson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923943002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923943002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
The CQ bit was checked by tomhudson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923943002/240001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tomhudson@google.com changed reviewers: + erg@chromium.org, fmalita@chromium.org, thestig@chromium.org
fmalita@: Skia reviewer. erg@: please review components/font_service/ thestig@: please review printing/ I propose to remove refptr.h itself in a separate CL (tomorrow?), and to use TBR for ash and blimp where we're just trimming unused #includes.
Description was changed from ========== Remove all uses of skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Remove all uses of skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 TBR=jamescook@chromium.org,wez@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
components/font_service lgtm
lgtm https://codereview.chromium.org/1923943002/diff/260001/printing/pdf_metafile_... File printing/pdf_metafile_skia.cc (left): https://codereview.chromium.org/1923943002/diff/260001/printing/pdf_metafile_... printing/pdf_metafile_skia.cc:159: halcanary@ just landed a change in this file. This may conflict.
lgtm
On 2016/06/09 00:14:20, Lei Zhang (Slow) wrote: > lgtm > > https://codereview.chromium.org/1923943002/diff/260001/printing/pdf_metafile_... > File printing/pdf_metafile_skia.cc (left): > > https://codereview.chromium.org/1923943002/diff/260001/printing/pdf_metafile_... > printing/pdf_metafile_skia.cc:159: > halcanary@ just landed a change in this file. This may conflict. Thanks for the heads up; done.
The CQ bit was checked by tomhudson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org, fmalita@chromium.org, erg@chromium.org Link to the patchset: https://codereview.chromium.org/1923943002/#ps280001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923943002/280001
Message was sent while issue was closed.
Description was changed from ========== Remove all uses of skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 TBR=jamescook@chromium.org,wez@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Remove all uses of skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 TBR=jamescook@chromium.org,wez@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #15 (id:280001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Remove all uses of skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 TBR=jamescook@chromium.org,wez@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Remove all uses of skia::RefPtr Finish deprecating skia::RefPtr in favor of sk_sp<>. This should significantly reduce the amount of manual reference management Chromium and Blink authors need to do for Skia objects. We still have some APIs vending raw pointers to ref-counted Skia objects which will need to be wrapped in sk_sp<>, but that should be easier and more predictable. This CL does *not* try to remove all cases of raw pointers to Skia objects in Chromium. BUG=skia:5077 TBR=jamescook@chromium.org,wez@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8691d7777e2ffbf7ea7ca351acc9dd02ab888d69 Cr-Commit-Position: refs/heads/master@{#398874} ==========
Message was sent while issue was closed.
Patchset 15 (id:??) landed as https://crrev.com/8691d7777e2ffbf7ea7ca351acc9dd02ab888d69 Cr-Commit-Position: refs/heads/master@{#398874} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
