Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1923893002: [counters] Annotate v8 with more runtime call counters. (Closed)

Created:
4 years, 7 months ago by Camillo Bruni
Modified:
4 years, 7 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[counters] Annotate v8 with more runtime call counters. By fully annotating the API with runtime counters we can properly measure how much time we spend in total in v8. When --runtime-call-stats is specified we now disable the fast-paths for callbacks to properly measure them. As a drive-by-fix this CL unifies the LOG messages in api.cc. Additionally we added missing timers to gain better resolution in the parser and callbacks. BUG= Committed: https://crrev.com/407d9fcec722d21e886eb581173240887fdd9c4c Cr-Commit-Position: refs/heads/master@{#36248}

Patch Set 1 #

Patch Set 2 : adding more timer scopes #

Patch Set 3 : update #

Patch Set 4 : cleanup #

Patch Set 5 : merge with master #

Patch Set 6 : keeping old log format #

Patch Set 7 : fixing few more things #

Total comments: 1

Patch Set 8 : merging master #

Patch Set 9 : addressing nit #

Patch Set 10 : removing unused macro #

Total comments: 2

Patch Set 11 : merging with master #

Patch Set 12 : using more consistent api log messages #

Patch Set 13 : intermediate merge artifact #

Patch Set 14 : fixing api counters #

Patch Set 15 : measure callback code generation and disable the fast path #

Patch Set 16 : directly return slow_stub #

Total comments: 2

Patch Set 17 : nits #

Patch Set 18 : merging master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+505 lines, -336 lines) Patch
M src/api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 133 chunks +267 lines, -302 lines 0 comments Download
M src/api-arguments.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +8 lines, -0 lines 0 comments Download
M src/api-arguments.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +3 lines, -0 lines 0 comments Download
M src/counters.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +176 lines, -13 lines 0 comments Download
M src/counters.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +18 lines, -4 lines 0 comments Download
M src/deoptimizer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +8 lines, -1 line 0 comments Download
M src/execution.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +16 lines, -8 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -0 lines 0 comments Download
M src/vm-state.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/vm-state-inl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 44 (20 generated)
Camillo Bruni
mstartzinger@ PTAL compiler.cc jochen@ the rest
4 years, 7 months ago (2016-05-04 12:31:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923893002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923893002/120001
4 years, 7 months ago (2016-05-06 08:54:06 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/17250) v8_linux64_rel_ng on ...
4 years, 7 months ago (2016-05-06 08:55:17 UTC) #7
Michael Starzinger
LGTM on compiler and full-codegen. Didn't look at the rest.
4 years, 7 months ago (2016-05-06 09:36:00 UTC) #8
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1923893002/diff/120001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1923893002/diff/120001/src/api.cc#newcode72 src/api.cc:72: i::Isolate* _log_isolate = isolate; \ why's that required?
4 years, 7 months ago (2016-05-06 09:39:54 UTC) #9
Camillo Bruni
jochen@: removed isolate tmp var
4 years, 7 months ago (2016-05-06 10:47:28 UTC) #10
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1923893002/diff/180001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1923893002/diff/180001/src/api.cc#newcode1154 src/api.cc:1154: LOG_API(i_isolate, FunctionTemplate_New, "FunctionTemplate::New"); sorry for not adding this comment ...
4 years, 7 months ago (2016-05-06 10:54:58 UTC) #11
Camillo Bruni
https://codereview.chromium.org/1923893002/diff/180001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1923893002/diff/180001/src/api.cc#newcode1154 src/api.cc:1154: LOG_API(i_isolate, FunctionTemplate_New, "FunctionTemplate::New"); On 2016/05/06 at 10:54:58, jochen wrote: ...
4 years, 7 months ago (2016-05-06 11:01:17 UTC) #12
jochen (gone - plz use gerrit)
On 2016/05/06 at 11:01:17, cbruni wrote: > https://codereview.chromium.org/1923893002/diff/180001/src/api.cc > File src/api.cc (right): > > https://codereview.chromium.org/1923893002/diff/180001/src/api.cc#newcode1154 ...
4 years, 7 months ago (2016-05-09 15:44:58 UTC) #13
Camillo Bruni
jochen PTAL again, changed now all messages and names to be predictable
4 years, 7 months ago (2016-05-11 14:27:46 UTC) #14
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-11 14:30:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923893002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923893002/220001
4 years, 7 months ago (2016-05-11 14:35:32 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/1492) v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-11 14:36:45 UTC) #20
Camillo Bruni
Igor can you have a look at ic.cc, I changed it to what we discussed ...
4 years, 7 months ago (2016-05-12 10:52:13 UTC) #22
Igor Sheludko
ic changes lgtm
4 years, 7 months ago (2016-05-12 11:19:37 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923893002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923893002/300001
4 years, 7 months ago (2016-05-12 11:25:13 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15130)
4 years, 7 months ago (2016-05-12 11:33:05 UTC) #29
Camillo Bruni
adamk@ could have a look at the added timers in parser/*?
4 years, 7 months ago (2016-05-12 15:37:45 UTC) #31
adamk
Besides the style nits, this lgtm structurally (given that these are being added in exactly ...
4 years, 7 months ago (2016-05-12 20:44:50 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923893002/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923893002/320001
4 years, 7 months ago (2016-05-13 13:59:50 UTC) #36
commit-bot: I haz the power
Failed to apply patch for src/api.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 7 months ago (2016-05-13 15:05:35 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923893002/340001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923893002/340001
4 years, 7 months ago (2016-05-13 15:22:50 UTC) #41
commit-bot: I haz the power
Committed patchset #18 (id:340001)
4 years, 7 months ago (2016-05-13 15:53:36 UTC) #42
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 15:54:56 UTC) #44
Message was sent while issue was closed.
Patchset 18 (id:??) landed as
https://crrev.com/407d9fcec722d21e886eb581173240887fdd9c4c
Cr-Commit-Position: refs/heads/master@{#36248}

Powered by Google App Engine
This is Rietveld 408576698