Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: third_party/qcms/src/transform_util.c

Issue 1923873002: [qcms] Make build_output_lut output 4096 points for parametric curves (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reordered declarations Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/qcms/src/transform_util.c
diff --git a/third_party/qcms/src/transform_util.c b/third_party/qcms/src/transform_util.c
index 3d84716ed553a5db9205bf560d03dfa4f0f64b1c..c22e88e3ccdd5a765a2e2b2bf0357e41fcefef7c 100644
--- a/third_party/qcms/src/transform_util.c
+++ b/third_party/qcms/src/transform_util.c
@@ -601,7 +601,7 @@ void build_output_lut(struct curveType *trc,
uint16_t i;
uint16_t *output = malloc(sizeof(uint16_t)*256);
uint16_t *inverted;
- int inverted_size = 256;
+ int inverted_size;
if (!output) {
*output_gamma_lut = NULL;
@@ -614,13 +614,8 @@ void build_output_lut(struct curveType *trc,
output[i] = (uint16_t)(gamma_table[i] * 65535);
}
- //XXX: the choice of a minimum of 256 here is not backed by any theory,
- // measurement or data, however it is what lcms uses.
- // the maximum number we would need is 65535 because that's the
- // accuracy used for computing the pre cache table
- if (inverted_size < 256)
- inverted_size = 256;
-
+ // XXX: Comment required.
+ inverted_size = 4096;
Noel Gordon 2016/04/28 07:30:27 Do this at line 604 diff-right. int inverted_size
radu.velea 2016/04/28 08:17:25 Done.
inverted = invert_lut(output, 256, inverted_size);
if (!inverted)
return;

Powered by Google App Engine
This is Rietveld 408576698