Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1923803003: [stubs] Micro optimizations to CodeAssember's allocation path (Closed)

Created:
4 years, 7 months ago by danno
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Micro optimizations to CodeAssember's allocation path Now that the GC team has landed the appropriate changes to ensure that the top page of the address space is never used for allocation, the inlined fast-case allocation path in the CodeAssembler can be micro-optimized to an add to top followed by an unsigned compare to limit, eliding a no-longer-needed overflow check. Committed: https://crrev.com/757d82eec5d27f5bf320d857f02e2fb27af6aa63 Cr-Commit-Position: refs/heads/master@{#35830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/code-stub-assembler.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danno
PTAL
4 years, 7 months ago (2016-04-27 12:27:02 UTC) #2
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-04-27 17:41:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923803003/1
4 years, 7 months ago (2016-04-27 17:42:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 17:44:24 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/757d82eec5d27f5bf320d857f02e2fb27af6aa63
Cr-Commit-Position: refs/heads/master@{#35830}

Powered by Google App Engine
This is Rietveld 408576698