Use InternalArrays from certain Intl code

Use InternalArrays from certain Intl code

The ECMA 402 implementation previously pushed directly to real
Arrays, which risks having observably incorrect behavior in the
presence of monkey patching. This patch uses InternalArrays instead
to avoid that hazard.

R=jshin@chromium.org,yangguo@chromium.org
BUG=chromium:604299
LOG=N

Committed: https://crrev.com/4f374bbc94f7958b0be4e6a15743eebe7c6eecf6
Cr-Commit-Position: refs/heads/master@{#35949}

[Dan Ehrenberg, 2016-04-27 04:34:30]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 04:34:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1923803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1923803002/1

[Yang, 2016-04-27 04:41:21]

https://codereview.chromium.org/1923803002/diff/1/src/js/i18n.js
File src/js/i18n.js (right):

https://codereview.chromium.org/1923803002/diff/1/src/js/i18n.js#newcode575
src/js/i18n.js:575: for (var i = 0; i < l; i++) {
Would %MoveArrayContents do the same?

[commit-bot: I haz the power, 2016-04-27 04:48:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 04:48:26]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/780)
  v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Dan Ehrenberg, 2016-04-27 04:51:34]

https://codereview.chromium.org/1923803002/diff/1/src/js/i18n.js
File src/js/i18n.js (right):

https://codereview.chromium.org/1923803002/diff/1/src/js/i18n.js#newcode575
src/js/i18n.js:575: for (var i = 0; i < l; i++) {
On 2016/04/27 at 04:41:21, Yang wrote:
> Would %MoveArrayContents do the same?

I'd still need to freeze each entry. Maybe Object.freeze afterwards would cover
it. Personally, I don't mind this phrasing because it parallels the spec text in
https://tc39.github.io/ecma402/#sec-supportedlocales .

[Dan Ehrenberg, 2016-04-27 05:30:28]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 05:30:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1923803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1923803002/20001

[commit-bot: I haz the power, 2016-04-27 05:55:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 05:55:43]

Dry run: This issue passed the CQ dry run.

[jungshik at Google, 2016-04-29 17:20:04]

Well, I guess I'm not yet qualified to review this CL :-) 
I'll use this CL as a reference to do the right thing (use InternalArray) in the
future when I touch i18n.js.

[Yang, 2016-05-02 10:24:16]

On 2016/04/29 17:20:04, jshin (jungshik at google) wrote:
> Well, I guess I'm not yet qualified to review this CL :-) 
> I'll use this CL as a reference to do the right thing (use InternalArray) in
the
> future when I touch i18n.js.

LGTM.

[Dan Ehrenberg, 2016-05-02 17:55:02]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-05-02 17:55:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1923803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1923803002/20001

[commit-bot: I haz the power, 2016-05-02 18:18:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-02 18:19:33]

Description was changed from

==========
Use InternalArrays from certain Intl code

The ECMA 402 implementation previously pushed directly to real
Arrays, which risks having observably incorrect behavior in the
presence of monkey patching. This patch uses InternalArrays instead
to avoid that hazard.

R=jshin@chromium.org,yangguo@chromium.org
BUG=chromium:604299
LOG=N
==========

to

==========
Use InternalArrays from certain Intl code

The ECMA 402 implementation previously pushed directly to real
Arrays, which risks having observably incorrect behavior in the
presence of monkey patching. This patch uses InternalArrays instead
to avoid that hazard.

R=jshin@chromium.org,yangguo@chromium.org
BUG=chromium:604299
LOG=N

Committed: https://crrev.com/4f374bbc94f7958b0be4e6a15743eebe7c6eecf6
Cr-Commit-Position: refs/heads/master@{#35949}
==========

[commit-bot: I haz the power, 2016-05-02 18:19:35]

Patchset 2 (id:??) landed as
https://crrev.com/4f374bbc94f7958b0be4e6a15743eebe7c6eecf6
Cr-Commit-Position: refs/heads/master@{#35949}