Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1923743002: Don’t cache constants in initializer expressions (Closed)

Created:
4 years, 8 months ago by hausner
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don’t cache constants in initializer expressions ... they will never be used again. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/77b328333f9392673ae50b0820789614dd850a4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M runtime/vm/parser.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
hausner
4 years, 8 months ago (2016-04-26 23:27:45 UTC) #4
rmacnak
LGTM
4 years, 8 months ago (2016-04-27 00:36:22 UTC) #5
hausner
4 years, 7 months ago (2016-04-27 16:28:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
77b328333f9392673ae50b0820789614dd850a4e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698