Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1923733002: Split protoc into library and executable. (Closed)

Created:
4 years, 8 months ago by xyzzyz
Modified:
4 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split protoc into library and executable. Similarly to the upstream BUILD file, we split the protoc compiler into a library and executable. The purpose is to allow protoc compiler plugins (see plugin.h). BUG=597321 Committed: https://crrev.com/132bbd301e93c7f92feed8f29a79539ea8a24c27 Cr-Commit-Position: refs/heads/master@{#390476}

Patch Set 1 #

Patch Set 2 : add changes to gyp #

Total comments: 6

Patch Set 3 : review round #

Total comments: 2

Patch Set 4 : update public deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -194 lines) Patch
M third_party/protobuf/BUILD.gn View 1 2 3 3 chunks +19 lines, -5 lines 0 comments Download
M third_party/protobuf/protobuf.gyp View 1 1 chunk +202 lines, -189 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
xyzzyz
Hi Peter, Could you review a small change in protobuf build files? It splits the ...
4 years, 8 months ago (2016-04-26 23:04:27 UTC) #2
Peter Kasting
https://codereview.chromium.org/1923733002/diff/20001/third_party/protobuf/BUILD.gn File third_party/protobuf/BUILD.gn (left): https://codereview.chromium.org/1923733002/diff/20001/third_party/protobuf/BUILD.gn#oldcode540 third_party/protobuf/BUILD.gn:540: deps += [ "//build/config/sanitizers:deps" ] This seems to have ...
4 years, 7 months ago (2016-04-27 22:30:17 UTC) #3
xyzzyz
https://codereview.chromium.org/1923733002/diff/20001/third_party/protobuf/BUILD.gn File third_party/protobuf/BUILD.gn (left): https://codereview.chromium.org/1923733002/diff/20001/third_party/protobuf/BUILD.gn#oldcode540 third_party/protobuf/BUILD.gn:540: deps += [ "//build/config/sanitizers:deps" ] On 2016/04/27 22:30:16, Peter ...
4 years, 7 months ago (2016-04-27 23:10:27 UTC) #4
Peter Kasting
Besides the comment below, the only real question I have left is whether the use ...
4 years, 7 months ago (2016-04-28 00:29:36 UTC) #5
xyzzyz
https://codereview.chromium.org/1923733002/diff/40001/third_party/protobuf/BUILD.gn File third_party/protobuf/BUILD.gn (right): https://codereview.chromium.org/1923733002/diff/40001/third_party/protobuf/BUILD.gn#newcode550 third_party/protobuf/BUILD.gn:550: ":protobuf_full", On 2016/04/28 00:29:36, Peter Kasting wrote: > If ...
4 years, 7 months ago (2016-04-28 20:00:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923733002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923733002/60001
4 years, 7 months ago (2016-04-28 20:02:21 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-28 20:57:36 UTC) #10
Justin Donnelly
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1929963004/ by jdonnelly@chromium.org. ...
4 years, 7 months ago (2016-04-28 21:31:43 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:21:01 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/132bbd301e93c7f92feed8f29a79539ea8a24c27
Cr-Commit-Position: refs/heads/master@{#390476}

Powered by Google App Engine
This is Rietveld 408576698