Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 192373008: ASSERTION FAILED: !style->propertyIsImportant(propertyID) in WebCore::setTextDecorationProperty (Closed)

Created:
6 years, 9 months ago by reni
Modified:
6 years, 9 months ago
Reviewers:
hayato
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

ASSERTION FAILED: !style->propertyIsImportant(propertyID) in WebCore::setTextDecorationProperty When remove format command is called we pushdown the ancestor style down to its children. Currently applying inline style to iframe while pushing down style which causes iframe to be reinserted in tree and triggres again subframe loading which repeats everytime and finally crash happens. So we should avoid applying inline style to iframe element as it does not reflect in its content while pushing down style on it. And ASSERT call has been removed from setTextDecoration property as the scenario is perfectly valid case. Backported from WebKit: http://trac.webkit.org/changeset/157710 (Patch by Santosh Mahto) R=hayato@chromium.org BUG=350943 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
A LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
reni
6 years, 9 months ago (2014-03-10 19:14:23 UTC) #1
hayato
LGTM
6 years, 9 months ago (2014-03-11 07:17:22 UTC) #2
reni
The CQ bit was checked by rhodovan.u-szeged@partner.samsung.com
6 years, 9 months ago (2014-03-11 08:28:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhodovan.u-szeged@partner.samsung.com/192373008/1
6 years, 9 months ago (2014-03-11 08:28:54 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 09:30:27 UTC) #5
Message was sent while issue was closed.
Change committed as 168900

Powered by Google App Engine
This is Rietveld 408576698