Issue 192373005: Use new is*Element() helper functions in CSS code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192373005: Use new is*Element() helper functions in CSS code (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
adamk, eseidel

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use new is*Element() helper functions in CSS code Use new is*Element() helpers in CSS code. This makes the code clearer and simpler. Also use the new Traversal<*Element> API where suitable. R=eseidel, adamk BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168847

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -49 lines)			Patch
M	Source/core/css/CSSCursorImageValue.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	Source/core/css/CSSDefaultStyleSheets.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSFontFaceSource.cpp	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	Source/core/css/CSSStyleSheet.cpp	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/css/StyleInvalidationAnalysis.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/StyleSheetList.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/css/resolver/ScopedStyleResolver.cpp	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	Source/core/css/resolver/SharedStyleFinder.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/resolver/StyleAdjuster.cpp	View	8 chunks	+14 lines, -12 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/192373005/1

6 years, 9 months ago (2014-03-10 18:15:44 UTC) #4

Message was sent while issue was closed.

Change committed as 168847

Expand Messages | Collapse Messages