Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1923683002: GN: Put BoringSSL Chromium specific targets inside a condition (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Put BoringSSL Chromium specific targets inside a condition The boringssl_unittests target depends on Chromium's base, so having it being processed by default results in errors for other projects reusing the GN files for BoringSSL that are located in the Chromium repo. TBR=kjellander@chromium.org, davidben@chromium.org BUG=webrtc:5829, 606944 Committed: https://crrev.com/1bbcf69d58af4e14e86019f59f75d669e2d2f65e Cr-Commit-Position: refs/heads/master@{#389932}

Patch Set 1 : patch from issue 1919383002, patchset 60001. #

Patch Set 2 : fix to webrtc.gni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -39 lines) Patch
M build_overrides/build.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M build_overrides/webrtc.gni View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/boringssl/BUILD.gn View 2 chunks +41 lines, -38 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Dirk Pranke
TBR'ing because of the approvals in 1919383002.
4 years, 7 months ago (2016-04-26 21:51:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923683002/20001
4 years, 7 months ago (2016-04-26 21:52:12 UTC) #5
davidben
lgtm
4 years, 7 months ago (2016-04-26 21:52:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-26 22:46:39 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1bbcf69d58af4e14e86019f59f75d669e2d2f65e Cr-Commit-Position: refs/heads/master@{#389932}
4 years, 7 months ago (2016-04-26 22:47:51 UTC) #10
kjellander_chromium
4 years, 7 months ago (2016-04-27 06:40:53 UTC) #11
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698