Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1923673002: Run the DOMStorageBrowserTest.SanityCheck against the mojo based implementation. (Closed)

Created:
4 years, 8 months ago by michaeln
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run the MojoDOMStorageBrowserTest SanityCheck against the mojo based local storage implementation. BUG=586194 Committed: https://crrev.com/0772f72dbec2e13ab2d536f0473d28a3c3c0d03b Cr-Commit-Position: refs/heads/master@{#391086}

Patch Set 1 #

Patch Set 2 : override keyword #

Patch Set 3 : bug fix #

Patch Set 4 : 4ken #

Patch Set 5 : disabled tests for now #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -14 lines) Patch
M content/browser/dom_storage/dom_storage_browsertest.cc View 1 2 3 4 5 6 3 chunks +20 lines, -0 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 2 3 4 5 6 2 chunks +15 lines, -0 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/leveldb_wrapper_impl.cc View 1 2 6 chunks +11 lines, -12 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/dom_storage/sanity_check.js View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
michaeln
ptal
4 years, 8 months ago (2016-04-26 21:35:01 UTC) #3
jam
lgtm
4 years, 8 months ago (2016-04-26 21:44:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923673002/20001
4 years, 8 months ago (2016-04-26 22:58:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/151222)
4 years, 8 months ago (2016-04-26 23:20:24 UTC) #9
michaeln
On 2016/04/26 23:20:24, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-27 00:17:56 UTC) #10
michaeln
ptal at the bug fix
4 years, 8 months ago (2016-04-27 01:33:31 UTC) #11
michaeln
Idk what is wrong on osx, looks like the tests actually pass but the harness ...
4 years, 7 months ago (2016-04-27 20:24:15 UTC) #12
michaeln
@rocket, snapshot 4ken alters the test to never signal completion so connection establishment is allowed ...
4 years, 7 months ago (2016-04-30 00:18:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923673002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923673002/120001
4 years, 7 months ago (2016-05-02 22:20:01 UTC) #17
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 7 months ago (2016-05-02 23:25:51 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 23:28:22 UTC) #21
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/0772f72dbec2e13ab2d536f0473d28a3c3c0d03b
Cr-Commit-Position: refs/heads/master@{#391086}

Powered by Google App Engine
This is Rietveld 408576698