Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Issue 1923663002: Don't suppress the load complete accessibility event (Closed)

Created:
4 years, 8 months ago by dmazzoni
Modified:
4 years, 7 months ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't suppress the load complete accessibility event Get rid of code that suppresses the load complete accessibility event when the window isn't focused. It was added when we suppressed focus events inside a tab when that window doesn't have focus, and that part of the change was valid - but that logic is now implemented in browser_accessibility_manager.cc, so this code here is redundant. Suppressing the load complete event was a speculative fix at the time but we now believe it was the wrong idea, it should fire even when the window is not currently focused. BUG=606949 Committed: https://crrev.com/668725525cd8bdcc7eef5d5e27564a9e1c07f026 Cr-Commit-Position: refs/heads/master@{#390230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_win.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
dmazzoni
4 years, 8 months ago (2016-04-26 21:02:30 UTC) #2
nektarios
lgtm
4 years, 8 months ago (2016-04-26 21:09:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923663002/1
4 years, 7 months ago (2016-04-27 02:34:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/128376) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-04-27 02:39:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923663002/1
4 years, 7 months ago (2016-04-27 02:57:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/128391) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-04-27 03:05:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923663002/1
4 years, 7 months ago (2016-04-27 23:16:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 23:23:11 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:14:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/668725525cd8bdcc7eef5d5e27564a9e1c07f026
Cr-Commit-Position: refs/heads/master@{#390230}

Powered by Google App Engine
This is Rietveld 408576698