Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 1923653002: Wire up process launch error codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 4061947e26511f2455ba2c8e414f46e0862b9dea..f8bbdc7ddb72734d6f38b2a82d4d904f975cbbc9 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -2613,15 +2613,15 @@ void RenderProcessHostImpl::OnProcessLaunched() {
#endif
}
-void RenderProcessHostImpl::OnProcessLaunchFailed() {
+void RenderProcessHostImpl::OnProcessLaunchFailed(int error_code) {
// If this object will be destructed soon, then observers have already been
// sent a RenderProcessHostDestroyed notification, and we must observe our
// contract that says that will be the last call.
if (deleting_soon_)
return;
- // TODO(wfh): Fill in the real error code here see crbug.com/526198.
- RendererClosedDetails details{base::TERMINATION_STATUS_LAUNCH_FAILED, -1};
+ RendererClosedDetails details{base::TERMINATION_STATUS_LAUNCH_FAILED,
+ error_code};
ProcessDied(true, &details);
}

Powered by Google App Engine
This is Rietveld 408576698