Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1923633004: Remove interface_factory_impl.h. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove interface_factory_impl.h. Neither InterfaceFactoryImpl nor InterfaceFactoryImplWithContext were used. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/83a3fb1a245806190d2615e519a317f7c3ff0193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -61 lines) Patch
M examples/content_handler_demo/content_handler_demo.cc View 1 chunk +0 lines, -1 line 0 comments Download
M examples/forwarding_content_handler/forwarding_content_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M examples/indirect_service/indirect_integer_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M examples/recursive_content_handler/recursive_content_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/application/content_handler_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/cpp/application/interface_factory_impl.h View 1 chunk +0 lines, -49 lines 0 comments Download
M services/java_handler/java_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/native_viewport/app_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/python/content_handler/content_handler_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/test_service/test_request_tracker_application.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/android_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/mojo/drm_ipc_init_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-04-27 20:47:44 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-04-27 20:54:22 UTC) #2
viettrungluu
4 years, 7 months ago (2016-04-27 20:55:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83a3fb1a245806190d2615e519a317f7c3ff0193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698