Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 1923573002: Convert //mojo/file_utils to use SynchronousInterfacePtr. (Closed)

Created:
4 years, 8 months ago by viettrungluu
Modified:
4 years, 8 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Convert //mojo/file_utils to use SynchronousInterfacePtr. (Also convert a use of ApplicationImpl::ConnectToServiceDeprecated().) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/0d10de6820a0d330ea65aac3bc7d8f04df7b6289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -126 lines) Patch
M mojo/file_utils/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/file_utils/file_util.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/file_utils/file_util.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M mojo/file_utils/file_util_unittest.cc View 2 chunks +61 lines, -99 lines 0 comments Download
M services/nacl/nonsfi/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/nacl/nonsfi/content_handler_main_pexe.cc View 6 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 8 months ago (2016-04-26 17:54:59 UTC) #1
vardhan
lgtm
4 years, 8 months ago (2016-04-26 18:08:03 UTC) #2
viettrungluu
4 years, 8 months ago (2016-04-26 18:17:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0d10de6820a0d330ea65aac3bc7d8f04df7b6289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698