Issue 1923573002: Convert //mojo/file_utils to use SynchronousInterfacePtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1923573002: Convert //mojo/file_utils to use SynchronousInterfacePtr. (Closed)

Created:
4 years, 8 months ago by viettrungluu

Modified:
4 years, 8 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Convert //mojo/file_utils to use SynchronousInterfacePtr. (Also convert a use of ApplicationImpl::ConnectToServiceDeprecated().) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/0d10de6820a0d330ea65aac3bc7d8f04df7b6289

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -126 lines)			Patch
M	mojo/file_utils/BUILD.gn	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/file_utils/file_util.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	mojo/file_utils/file_util.cc	View	2 chunks	+10 lines, -12 lines	0 comments	Download
M	mojo/file_utils/file_util_unittest.cc	View	2 chunks	+61 lines, -99 lines	0 comments	Download
M	services/nacl/nonsfi/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	services/nacl/nonsfi/content_handler_main_pexe.cc	View	6 chunks	+10 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 8 months ago (2016-04-26 18:17:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0d10de6820a0d330ea65aac3bc7d8f04df7b6289 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages