Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1923533003: [Layout API] Convert ViewportScrollCallback to use Document::layoutViewItem() (Closed)

Created:
4 years, 8 months ago by pilgrim_google
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews, dgrogan, kenneth.christiansen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Convert ViewportScrollCallback to use Document::layoutViewItem() There were several references to Document::layoutView() which is deprecated by the new layout API. I converted them to use layoutViewItem() instead. No new API methods were required. There are no functional changes. BUG=499321 Committed: https://crrev.com/e3a4314bf9806e94ff93337a7db43c932039427b Cr-Commit-Position: refs/heads/master@{#389911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
4 years, 8 months ago (2016-04-26 18:57:16 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 8 months ago (2016-04-26 20:38:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923533003/1
4 years, 8 months ago (2016-04-26 20:39:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 22:04:54 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 22:07:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3a4314bf9806e94ff93337a7db43c932039427b
Cr-Commit-Position: refs/heads/master@{#389911}

Powered by Google App Engine
This is Rietveld 408576698