Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 19235014: Add WebRTC DEPS for Android builds. (Closed)

Created:
7 years, 5 months ago by kjellander_chromium
Modified:
7 years, 5 months ago
Reviewers:
hellner1, hellner
CC:
chromium-reviews
Visibility:
Public.

Description

Add WebRTC DEPS for Android builds. This DEPS makes it possible to pull required additional dependencies for Chromium that are needed to build and execute WebRTC Android tests using Chromium's Android test framework. In addition to this deps solution, custom deps are needed for src/third_party/webrtc in order to checkout the latest code instead of the DEPS pinned revision of WebRTC stable branch. BUG=webrtc:2059 TEST=checked in the file in a local Subversion repo and tested adding it as a separate solution, followed by a successful gclient sync, with a .gclient configured for Android (see https://code.google.com/p/chromium/wiki/AndroidBuildInstructions for details). R=hellner@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211964

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
A webrtc/webrtc.DEPS/DEPS View 1 chunk +19 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
kjellander_chromium
Hi, using this DEPS file, we can avoid having these configuration details kept in the ...
7 years, 5 months ago (2013-07-16 21:17:10 UTC) #1
hellner
LGTM with one comment. https://codereview.chromium.org/19235014/diff/2001/webrtc/webrtc.DEPS/DEPS File webrtc/webrtc.DEPS/DEPS (right): https://codereview.chromium.org/19235014/diff/2001/webrtc/webrtc.DEPS/DEPS#newcode1 webrtc/webrtc.DEPS/DEPS:1: # DEPS file that pulls ...
7 years, 5 months ago (2013-07-17 02:06:06 UTC) #2
hellner
LGTM with one comment.
7 years, 5 months ago (2013-07-17 02:06:07 UTC) #3
kjellander_chromium
Replied to your comments. I will submit this now and start looking at configuring the ...
7 years, 5 months ago (2013-07-17 05:51:26 UTC) #4
kjellander_chromium
7 years, 5 months ago (2013-07-17 05:52:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r211964 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698