Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1923493002:
Roll src/third_party/pdfium 0f6425f:3081cc0 (Closed)
|
Created:
4 years, 8 months ago by Michael Achenbach Modified:
4 years, 8 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
chromium-reviews, dsinclair, Oliver Chang Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll src/third_party/pdfium 0f6425f:3081cc0
Summary of changes available at:
https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0
BUG=606547
TBR=jochen@chromium.org
Committed: https://crrev.com/65639bcd2b4a2eb9578988651bf64c42761102c1
Cr-Commit-Position: refs/heads/master@{#389759}
Patch Set 1 #Messages
Total messages: 21 (11 generated)
Description was changed from ========== Roll src/third_party/pdfium 0f6425f:3081cc0 Summary of changes available at: https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0 BUG= ========== to ========== Roll src/third_party/pdfium 0f6425f:3081cc0 Summary of changes available at: https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0 BUG=474921, 606547 ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923493002/1
PTAL
CC creator + reviewer of last roll
Description was changed from ========== Roll src/third_party/pdfium 0f6425f:3081cc0 Summary of changes available at: https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0 BUG=474921, 606547 ========== to ========== Roll src/third_party/pdfium 0f6425f:3081cc0 Summary of changes available at: https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0 BUG=606547 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923493002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Roll src/third_party/pdfium 0f6425f:3081cc0 Summary of changes available at: https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0 BUG=606547 ========== to ========== Roll src/third_party/pdfium 0f6425f:3081cc0 Summary of changes available at: https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0 BUG=606547 TBR=jochen@chromium.org ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923493002/1
Message was sent while issue was closed.
Description was changed from ========== Roll src/third_party/pdfium 0f6425f:3081cc0 Summary of changes available at: https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0 BUG=606547 TBR=jochen@chromium.org ========== to ========== Roll src/third_party/pdfium 0f6425f:3081cc0 Summary of changes available at: https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0 BUG=606547 TBR=jochen@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll src/third_party/pdfium 0f6425f:3081cc0 Summary of changes available at: https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0 BUG=606547 TBR=jochen@chromium.org ========== to ========== Roll src/third_party/pdfium 0f6425f:3081cc0 Summary of changes available at: https://pdfium.googlesource.com/pdfium/+log/0f6425f..3081cc0 BUG=606547 TBR=jochen@chromium.org Committed: https://crrev.com/65639bcd2b4a2eb9578988651bf64c42761102c1 Cr-Commit-Position: refs/heads/master@{#389759} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/65639bcd2b4a2eb9578988651bf64c42761102c1 Cr-Commit-Position: refs/heads/master@{#389759}
Message was sent while issue was closed.
lgtm |
