Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1923473003: [UI->Navigation] Forward navigation button issue with onbeforeunload dialog

Created:
4 years, 7 months ago by ranap
Modified:
4 years, 7 months ago
Reviewers:
rnimmagadda
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UI->Navigation] Forward navigation button issue with onbeforeunload dialog Forward navigation button on toolbar gets enabled even though there is unload confirmation dialog and it remians in enabled state even after dialog box is closed with "Stay" There are two possible fixes 1> Do not enable the forward navigation button till user accept the navigation with "Leave" 2> Disable it back when user cancel the navigation with "Stay" This patchset is based on the option two mentioned above BUG=603805 TEST=Login to http://demo.redmine.org site with some credentials. (1) Go to any issue link present in http://demo.redmine.org/issues/ (2) Click the Edit link -> Text area box will appear (3) Put some characters in the text box (4) Press back button from the toolbar (5) modal dialog to confirm navigate back will appear and forward navigation button will be enabled (6) Click "Stay on this Page" button (7) Verify that the forward navigation button is disabled after the dialog is closed R=rnimmagadda@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ranap
4 years, 7 months ago (2016-04-26 19:03:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698