Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1923453003: [build] Switch to moved v8.gyp (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, aboxhall+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org, ben+mojo_chromium.org, blink-reviews, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, Michael Hablich, halliwell+watch_chromium.org, haraken, jam, je_julie, jochen+watch_chromium.org, kinuko+watch, lcwu+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, nektar+watch_chromium.org, oshima+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yuzo+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -52 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/gn_migration.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M build/linux/unbundle/replace_gyp_files.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/guest_view.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/pdf.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/plugins.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/test_runner.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/translate.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content.gyp View 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gin/gin.gyp View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/mojo_edk.gyp View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core.gyp View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/web.gyp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/web_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923453003/1
4 years, 8 months ago (2016-04-26 09:00:10 UTC) #3
Michael Achenbach
PTAL
4 years, 8 months ago (2016-04-26 09:00:57 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-26 09:18:14 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 10:31:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923453003/1
4 years, 8 months ago (2016-04-26 12:26:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/173234)
4 years, 8 months ago (2016-04-26 12:33:53 UTC) #12
Michael Achenbach
TBR to other missing owners according to presubmit
4 years, 8 months ago (2016-04-26 12:45:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923453003/1
4 years, 8 months ago (2016-04-26 12:45:49 UTC) #17
Torne
lgtm
4 years, 8 months ago (2016-04-26 12:48:41 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 12:52:38 UTC) #20
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/60b9aa2bbf35e9855499d9aec11cbbab43387044 Cr-Commit-Position: refs/heads/master@{#389760}
4 years, 8 months ago (2016-04-26 12:54:33 UTC) #22
James Cook
4 years, 8 months ago (2016-04-26 14:19:19 UTC) #23
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698