Stop listening for CONNECTIVITY_ACTION in precache

Stop listening for CONNECTIVITY_ACTION in precache

Precache listens for CONNECTIVITY_ACTION in ChromeTabbedActivity to
update the precache shared preference, and to schedule/cancel GCM task
for precache.

This is redundant since the same happens via DeferredStartupHandler::
onDeferredStartup

BUG=585263
Committed: https://crrev.com/163257bbe7e4c20020fcb5223f6f40badac7d730
Cr-Commit-Position: refs/heads/master@{#390300}

[Raj, 2016-04-26 04:44:31]

rajendrant@chromium.org changed reviewers:
+ bengr@chromium.org, twifkak@chromium.org

[Raj, 2016-04-26 04:44:31]

PTAL

[Raj, 2016-04-26 04:50:37]

Description was changed from

==========
Stop listening for CONNECTIVITY_ACTION in precache

Precache listens for CONNECTIVITY_ACTION in ChromeTabbedActivity to
update the precache shared preference, and to schedule/cancel GCM task
for precache.

This is redundant since the same happens via DeferredStartupHandler::
onDeferredStartup

BUG=585263
==========

to

==========
Stop listening for CONNECTIVITY_ACTION in precache

Precache listens for CONNECTIVITY_ACTION in ChromeTabbedActivity to
update the precache shared preference, and to schedule/cancel GCM task
for precache.

This is redundant since the same happens via DeferredStartupHandler::
onDeferredStartup

BUG=585263
==========

[Raj, 2016-04-26 04:50:37]

rajendrant@chromium.org changed reviewers:
+ battre@chromium.org

[Raj, 2016-04-26 04:51:12]

rajendrant@chromium.org changed reviewers:
+ yfriedman@chromium.org
- battre@chromium.org

[bengr, 2016-04-27 23:23:15]

lgtm

[Raj, 2016-04-27 23:41:05]

On 2016/04/27 23:23:15, bengr wrote:
> lgtm

yaron: ptal
chrome/android/java/src/org/chromium/chrome/browser/*

[Yaron, 2016-04-28 03:51:41]

It's not entirely redundant though. DeferredStartupHandler runs exactly once
whereas this would listen to connectivity changes for the lifetime of the app.
Oh but it seems to be using TaskScheduler and requires an unmetered network so
seems like it should be fine. 

lgtm

[Raj, 2016-04-28 03:58:38]

On 2016/04/28 03:51:41, Yaron wrote:
> It's not entirely redundant though. DeferredStartupHandler runs exactly once
> whereas this would listen to connectivity changes for the lifetime of the app.
> Oh but it seems to be using TaskScheduler and requires an unmetered network so
> seems like it should be fine. 
> 
> lgtm

Thanks. Yes, we use GCMNetworkManager for scheduling when on unmetered network
and connected with power.

[Raj, 2016-04-28 03:58:42]

The CQ bit was checked by rajendrant@chromium.org

[commit-bot: I haz the power, 2016-04-28 03:58:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1923443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1923443002/1

[commit-bot: I haz the power, 2016-04-28 04:52:29]

Description was changed from

==========
Stop listening for CONNECTIVITY_ACTION in precache

Precache listens for CONNECTIVITY_ACTION in ChromeTabbedActivity to
update the precache shared preference, and to schedule/cancel GCM task
for precache.

This is redundant since the same happens via DeferredStartupHandler::
onDeferredStartup

BUG=585263
==========

to

==========
Stop listening for CONNECTIVITY_ACTION in precache

Precache listens for CONNECTIVITY_ACTION in ChromeTabbedActivity to
update the precache shared preference, and to schedule/cancel GCM task
for precache.

This is redundant since the same happens via DeferredStartupHandler::
onDeferredStartup

BUG=585263
==========

[commit-bot: I haz the power, 2016-04-28 04:52:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 17:16:13]

Patchset 1 (id:??) landed as
https://crrev.com/163257bbe7e4c20020fcb5223f6f40badac7d730
Cr-Commit-Position: refs/heads/master@{#390300}

[commit-bot: I haz the power, 2016-04-30 17:54:11]

Description was changed from

==========
Stop listening for CONNECTIVITY_ACTION in precache

Precache listens for CONNECTIVITY_ACTION in ChromeTabbedActivity to
update the precache shared preference, and to schedule/cancel GCM task
for precache.

This is redundant since the same happens via DeferredStartupHandler::
onDeferredStartup

BUG=585263
==========

to

==========
Stop listening for CONNECTIVITY_ACTION in precache

Precache listens for CONNECTIVITY_ACTION in ChromeTabbedActivity to
update the precache shared preference, and to schedule/cancel GCM task
for precache.

This is redundant since the same happens via DeferredStartupHandler::
onDeferredStartup

BUG=585263

Committed: https://crrev.com/163257bbe7e4c20020fcb5223f6f40badac7d730
Cr-Commit-Position: refs/heads/master@{#390300}
==========