chrome/browser/extensions/activity_log/stream_noargs_ui_policy_unittest.cc - Issue 19234003: Extension activity log database refactoring (step 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/stream_noargs_ui_policy_unittest.cc

Issue 19234003: Extension activity log database refactoring (step 2) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address some reviewer comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc ('k') | chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/stream_noargs_ui_policy_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/stream_noargs_ui_policy_unittest.cc b/chrome/browser/extensions/activity_log/stream_noargs_ui_policy_unittest.cc

index a1c806d6d8ca42c14f42c58b6e4a0ca88a659dce..1a5dd4a5d5d451ec53ce15d32e96500138911508 100644

--- a/chrome/browser/extensions/activity_log/stream_noargs_ui_policy_unittest.cc

+++ b/chrome/browser/extensions/activity_log/stream_noargs_ui_policy_unittest.cc

@@ -66,8 +66,9 @@ class StreamWithoutArgsUIPolicyTest : public testing::Test {

static void Arguments_Missing(

scoped_ptr<std::vector<scoped_refptr<Action> > > i) {

scoped_refptr<Action> last = i->front();

- std::string noargs = "ID: odlameecjipmbmbejkplpemijjgpljce, CATEGORY: "

- "call, API: tabs.testMethod, ARGS: ";

+ std::string noargs =

+ "ID=odlameecjipmbmbejkplpemijjgpljce CATEGORY=api_call "

+ "API=tabs.testMethod ARGS=[] OTHER={}";

ASSERT_EQ(noargs, last->PrintForDebug());

}