Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3474)

Unified Diff: chrome/browser/extensions/activity_log/fullstream_ui_policy.h

Issue 19234003: Extension activity log database refactoring (step 2) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address some reviewer comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/fullstream_ui_policy.h
diff --git a/chrome/browser/extensions/activity_log/fullstream_ui_policy.h b/chrome/browser/extensions/activity_log/fullstream_ui_policy.h
index 3b33963fcadf225b1d5e35479fe7a3fbc88f3b31..f915ad5ee4beb0a2b72b83cff0848c6c69acc6b9 100644
--- a/chrome/browser/extensions/activity_log/fullstream_ui_policy.h
+++ b/chrome/browser/extensions/activity_log/fullstream_ui_policy.h
@@ -45,6 +45,12 @@ class FullStreamUIPolicy : public ActivityLogPolicy,
virtual void Close() OVERRIDE;
+ // Database table schema.
+ static const char* kTableName;
+ static const char* kTableContentFields[];
+ static const char* kTableFieldTypes[];
+ static const int kTableFieldCount;
+
protected:
// Only ever run by OnDatabaseClose() below; see the comments on the
// ActivityDatabase class for an overall discussion of how cleanup works.
@@ -55,10 +61,16 @@ class FullStreamUIPolicy : public ActivityLogPolicy,
virtual bool OnDatabaseInit(sql::Connection* db) OVERRIDE;
virtual void OnDatabaseClose() OVERRIDE;
- // Concatenates arguments
- virtual std::string ProcessArguments(ActionType action_type,
- const std::string& name,
- const base::ListValue* args) const;
+ // Strips arguments if needed by policy.
+ virtual scoped_ptr<base::ListValue> ProcessArguments(
+ ActionType action_type,
+ const std::string& name,
+ const base::ListValue* args) const;
+
+ // Concatenates arguments.
+ virtual std::string JoinArguments(ActionType action_type,
+ const std::string& name,
+ const base::ListValue* args) const;
virtual void ProcessWebRequestModifications(
base::DictionaryValue& details,
« no previous file with comments | « chrome/browser/extensions/activity_log/dom_actions.cc ('k') | chrome/browser/extensions/activity_log/fullstream_ui_policy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698