Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/browser/extensions/activity_log/dom_actions.h

Issue 19234003: Extension activity log database refactoring (step 2) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address some reviewer comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/dom_actions.h
diff --git a/chrome/browser/extensions/activity_log/dom_actions.h b/chrome/browser/extensions/activity_log/dom_actions.h
index 1eff74b94d7311f84e7e3965ee00bc9c2b707217..9129a39486888409524caaf87caac8337617ea49 100644
--- a/chrome/browser/extensions/activity_log/dom_actions.h
+++ b/chrome/browser/extensions/activity_log/dom_actions.h
@@ -16,14 +16,6 @@ namespace extensions {
// content script insertions.
class DOMAction : public Action {
public:
- static const char* kTableName;
- static const char* kTableContentFields[];
- static const char* kTableFieldTypes[];
-
- // Create a new database table for storing DOMActions, or update the schema if
- // it is out of date. Any existing data is preserved.
- static bool InitializeTable(sql::Connection* db);
-
// Create a new DOMAction to describe a new DOM API call.
// If the DOMAction is on a background page, the url & url_title may be null.
// If the DOMAction refers to a content script insertion, api_call may be null
@@ -38,9 +30,6 @@ class DOMAction : public Action {
const std::string& args, // the args
const std::string& extra); // any extra logging info
- // Create a new DOMAction from a database row.
- explicit DOMAction(const sql::Statement& s);
-
virtual scoped_ptr<api::activity_log_private::ExtensionActivity>
ConvertToExtensionActivity() OVERRIDE;
« no previous file with comments | « chrome/browser/extensions/activity_log/blocked_actions.cc ('k') | chrome/browser/extensions/activity_log/dom_actions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698