Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1917)

Unified Diff: chrome/browser/extensions/activity_log/activity_log_browsertest.cc

Issue 19234003: Extension activity log database refactoring (step 2) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address some reviewer comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log_browsertest.cc
diff --git a/chrome/browser/extensions/activity_log/activity_log_browsertest.cc b/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
index 6bb158fbb8bf347229bd470ca72c0b46019b1b1f..0b5ee0a5e47912793c7843bb4b6578d1cf4bd310 100644
--- a/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
+++ b/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
@@ -34,7 +34,9 @@ class ActivityLogPrerenderTest : public ExtensionApiTest {
switches::kPrerenderModeSwitchValueEnabled);
}
- static void Prerender_Arguments(int port,
+ static void Prerender_Arguments(
+ const std::string& extension_id,
+ int port,
scoped_ptr<std::vector<scoped_refptr<Action> > > i) {
// This is to exit RunLoop (base::MessageLoop::current()->Run()) below
base::MessageLoop::current()->PostTask(
@@ -44,9 +46,11 @@ class ActivityLogPrerenderTest : public ExtensionApiTest {
scoped_refptr<Action> last = i->front();
std::string args = base::StringPrintf(
- "Injected scripts (\"/google_cs.js \") "
- "onto http://www.google.com.bo:%d/test.html (prerender)",
- port);
+ "ID=%s CATEGORY=content_script API= ARGS=[\"\\\"/google_cs.js \\\"\"] "
+ "PAGE_URL=http://www.google.com.bo:%d/test.html "
+ "OTHER={\"dom_verb\":3,\"extra\":\"(prerender)\",\"page_title\":\"www."
+ "google.com.bo:%d/test.html\"}",
+ extension_id.c_str(), port, port);
// TODO: Replace PrintForDebug with field testing
// when this feature will be available
ASSERT_EQ(args, last->PrintForDebug());
@@ -98,7 +102,7 @@ IN_PROC_BROWSER_TEST_F(ActivityLogPrerenderTest, TestScriptInjected) {
activity_log->GetActions(
ext->id(), 0, base::Bind(
- ActivityLogPrerenderTest::Prerender_Arguments, port));
+ ActivityLogPrerenderTest::Prerender_Arguments, ext->id(), port));
// Allow invocation of Prerender_Arguments
base::MessageLoop::current()->Run();

Powered by Google App Engine
This is Rietveld 408576698