Extension activity log database refactoring (step 2)

chrome/browser/extensions/activity_log/api_actions.h

Index: chrome/browser/extensions/activity_log/api_actions.h
diff --git a/chrome/browser/extensions/activity_log/api_actions.h b/chrome/browser/extensions/activity_log/api_actions.h
index 4cd3cb07969fb0b3496750a9a151be3a8849befc..9ea84baa16b1987aced430ef560e4e598581003b 100644
--- a/chrome/browser/extensions/activity_log/api_actions.h
+++ b/chrome/browser/extensions/activity_log/api_actions.h
@@ -22,18 +22,11 @@ class APIAction : public Action {
     UNKNOWN_TYPE = 2,
   };
 
-  static const char* kTableName;
-  static const char* kTableContentFields[];
-  static const char* kTableFieldTypes[];
   static const char* kAlwaysLog[];
   static const int kSizeAlwaysLog;
 
   static const char* kIncognitoUrl;
 
-  // Create the database table for storing APIActions, or update the schema if
-  // it is out of date.  Any existing data is preserved.
-  static bool InitializeTable(sql::Connection* db);
-
   // Create a new APIAction to describe a successful API call.  All
   // parameters are required.
   APIAction(const std::string& extension_id,
@@ -41,11 +34,9 @@ class APIAction : public Action {
             const Type type,              // e.g. "CALL"
             const std::string& api_call,  // full method name
             const std::string& args,      // the argument list
+            const base::ListValue& args_list,  // same as above, as a list

[Matt Perry, 2013/07/17 22:13:19]

why have this redundant data? APIAction should just store one or the other.

[mvrable, 2013/07/17 22:56:35]

We're moving towards just using the ListValue, but keeping both around made some
of the transition easier.  In the patch after this one, the APIAction class is
gone entirely and so this is cleaned up.

If you think it's worth spending the effort I could try to get rid of args in
this patch.

[Matt Perry, 2013/07/17 23:10:27]

No that's fine, good to hear you're planning on fixing it.

             const std::string& extra);    // any extra logging info
 
-  // Create a new APIAction from a database row.
-  explicit APIAction(const sql::Statement& s);
-
   // Record the action in the database.
   virtual bool Record(sql::Connection* db) OVERRIDE;
 
@@ -76,6 +67,7 @@ class APIAction : public Action {
   Type type_;
   std::string api_call_;
   std::string args_;
+  scoped_ptr<base::ListValue> args_list_;
   std::string extra_;
 
   DISALLOW_COPY_AND_ASSIGN(APIAction);