DevTools: fix styles and input validation in sensor pane

third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @param {number} latitude
  * @param {number} longitude
  * @param {boolean} error
  */
@@ skipping 67 matching lines @@
     var longitude = isLongitudeValid ? parseFloat(longitudeString) : -1;
     return new WebInspector.Geolocation(latitude, longitude, !!errorStatus);
 }
 
 /**
  * @param {string} value
  * @return {boolean}
  */
 WebInspector.Geolocation.latitudeValidator = function(value)
 {
-    return !value || (/^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && value >= -90 && value <= 90);
+    var numValue = parseFloat(value);
+    return /^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && numValue >= -90 && numValue <= 90;
 }
 
 /**
  * @param {string} value
  * @return {boolean}
  */
 WebInspector.Geolocation.longitudeValidator = function(value)
 {
-    return !value || (/^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && value >= -180 && value <= 180);
+    var numValue = parseFloat(value);
+    return /^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && numValue >= -180 && numValue <= 180;

[lushnikov, 2016/05/04 17:10:45]

Is this regex just a fancy way of saying "this is a number"?

return !isNaN(value) && numValue >= -180 && numValue <= 180

[luoe, 2016/05/04 17:31:10]

Not quite.  One case, value="1-0", parseFloat("1-0") === 1, and isNaN(1) ===
false.  However we don't want this to be a valid geolocation.

 }
 
 WebInspector.Geolocation.DefaultMockAccuracy = 150;