DevTools: fix styles and input validation in sensor pane

DevTools: fix styles and input validation in sensor pane

BUG=607491, 607511
Committed: https://crrev.com/6fd06ffec9d7e331e754d77bfd8e11e780b17f70
Cr-Commit-Position: refs/heads/master@{#391603}

[luoe, 2016-04-29 17:32:24]

Description was changed from

==========
DevTools: fix scscroll regression in sensor pane

BUG=607491
==========

to

==========
DevTools: fix style regressions in sensor pane

BUG=607491
==========

[luoe, 2016-04-29 18:52:45]

Description was changed from

==========
DevTools: fix style regressions in sensor pane

BUG=607491
==========

to

==========
DevTools: fix styles and input validation in sensor pane

BUG=607491,607511
==========

[luoe, 2016-04-29 18:52:45]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[chowse, 2016-04-29 20:12:21]

On 2016/04/29 18:52:45, luoe wrote:
> mailto:luoe@chromium.org changed reviewers:
> + mailto:lushnikov@chromium.org

Small nit: The labels used for the accelerometer should probably match those
used in public documentation around deviceorientation (e.g.
https://developer.mozilla.org/en-US/docs/Web/Events/deviceorientation). I.e. the
labels should be:

Rotation (α)
Up/down tilt (β)
Left/right tilt (γ)

[luoe, 2016-04-29 21:01:46]

On 2016/04/29 20:12:21, chowse wrote:
> On 2016/04/29 18:52:45, luoe wrote:
> > mailto:luoe@chromium.org changed reviewers:
> > + mailto:lushnikov@chromium.org
> 
> Small nit: The labels used for the accelerometer should probably match those
> used in public documentation around deviceorientation (e.g.
> https://developer.mozilla.org/en-US/docs/Web/Events/deviceorientation). I.e.
the
> labels should be:
> 
> Rotation (α)
> Up/down tilt (β)
> Left/right tilt (γ)

@chowse The updated labels should appear in Patch set 3

[lushnikov, 2016-05-02 19:25:57]

https://codereview.chromium.org/1923393006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js
(right):

https://codereview.chromium.org/1923393006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js:88: return
/^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && value >= -90 && value <= 90;
value >= -90

while we're here - let's not use implicit type conversions.

https://codereview.chromium.org/1923393006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js:97: return
/^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && value >= -180 && value <=
180;
ditto

https://codereview.chromium.org/1923393006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
(right):

https://codereview.chromium.org/1923393006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js:271:
this._alphaSetter = this._createAxisInput(cellElement, this._alphaElement,
WebInspector.UIString("Rotation (\u03B1)"));
can we use roll/pitch/yaw here to define angels? This is common in both android
and iOS SDK.

iOS:
https://developer.apple.com/library/ios/documentation/CoreMotion/Reference/CM...
Android:
http://developer.android.com/reference/android/hardware/SensorListener.html

[luoe, 2016-05-02 21:46:18]

https://codereview.chromium.org/1923393006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js
(right):

https://codereview.chromium.org/1923393006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js:88: return
/^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && value >= -90 && value <= 90;
On 2016/05/02 19:25:57, lushnikov wrote:
> value >= -90
> 
> while we're here - let's not use implicit type conversions.

Done.

https://codereview.chromium.org/1923393006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js:97: return
/^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && value >= -180 && value <=
180;
On 2016/05/02 19:25:57, lushnikov wrote:
> ditto

Done, using parseFloat.

https://codereview.chromium.org/1923393006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
(right):

https://codereview.chromium.org/1923393006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js:271:
this._alphaSetter = this._createAxisInput(cellElement, this._alphaElement,
WebInspector.UIString("Rotation (\u03B1)"));
On 2016/05/02 19:25:57, lushnikov wrote:
> can we use roll/pitch/yaw here to define angels? This is common in both
android
> and iOS SDK.
> 
> iOS:
>
https://developer.apple.com/library/ios/documentation/CoreMotion/Reference/CM...
> Android:
> http://developer.android.com/reference/android/hardware/SensorListener.html

Roll/pitch/yaw looks like a common pattern for mobile dev, but most Device
Orientation docs and tutorials look similar to this:
https://developer.mozilla.org/en-US/docs/Web/API/Detecting_device_orientation
which uses rotation, left/right, front/back.

I'm not in strong favor of either way, because they both sound ambiguous to me. 
Roll/pitch/yaw depends on what the "front" and "back" of a phone are, while
"left/right" and "rotation" could be interchangeable.

[luoe, 2016-05-04 15:56:25]

Orientation labels adjusted.  Ready for review

[lushnikov, 2016-05-04 17:10:46]

lgtm

https://codereview.chromium.org/1923393006/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js
(right):

https://codereview.chromium.org/1923393006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js:99: return
/^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && numValue >= -180 && numValue
<= 180;
Is this regex just a fancy way of saying "this is a number"?

return !isNaN(value) && numValue >= -180 && numValue <= 180

[luoe, 2016-05-04 17:31:10]

https://codereview.chromium.org/1923393006/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js
(right):

https://codereview.chromium.org/1923393006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js:99: return
/^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && numValue >= -180 && numValue
<= 180;
On 2016/05/04 17:10:45, lushnikov wrote:
> Is this regex just a fancy way of saying "this is a number"?
> 
> return !isNaN(value) && numValue >= -180 && numValue <= 180

Not quite.  One case, value="1-0", parseFloat("1-0") === 1, and isNaN(1) ===
false.  However we don't want this to be a valid geolocation.

[luoe, 2016-05-04 18:07:31]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 18:08:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1923393006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1923393006/80001

[commit-bot: I haz the power, 2016-05-04 19:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 19:47:10]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-05-04 19:49:09]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-05-04 19:49:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1923393006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1923393006/80001

[commit-bot: I haz the power, 2016-05-04 19:59:16]

Description was changed from

==========
DevTools: fix styles and input validation in sensor pane

BUG=607491,607511
==========

to

==========
DevTools: fix styles and input validation in sensor pane

BUG=607491,607511
==========

[commit-bot: I haz the power, 2016-05-04 19:59:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-04 20:01:13]

Description was changed from

==========
DevTools: fix styles and input validation in sensor pane

BUG=607491,607511
==========

to

==========
DevTools: fix styles and input validation in sensor pane

BUG=607491,607511

Committed: https://crrev.com/6fd06ffec9d7e331e754d77bfd8e11e780b17f70
Cr-Commit-Position: refs/heads/master@{#391603}
==========

[commit-bot: I haz the power, 2016-05-04 20:01:14]

Patchset 5 (id:??) landed as
https://crrev.com/6fd06ffec9d7e331e754d77bfd8e11e780b17f70
Cr-Commit-Position: refs/heads/master@{#391603}