Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1923373004: [mojo-edk] Move the selector in Node::GetMessageIf instead of copying it. (Closed)

Created:
4 years, 7 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Move the selector in Node::GetMessageIf instead of copying it. The copy is an extra unnecessary allocation on every message read. BUG=None Committed: https://crrev.com/452ce11289633ebc3e5b1fffe17d99702bef6496 Cr-Commit-Position: refs/heads/master@{#390296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M mojo/edk/system/ports/node.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Anand Mistry (off Chromium)
Low-hanging fruit.
4 years, 7 months ago (2016-04-28 02:35:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923373004/1
4 years, 7 months ago (2016-04-28 02:35:44 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-04-28 03:18:42 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 03:25:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923373004/1
4 years, 7 months ago (2016-04-28 04:00:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 04:04:50 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:16:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/452ce11289633ebc3e5b1fffe17d99702bef6496
Cr-Commit-Position: refs/heads/master@{#390296}

Powered by Google App Engine
This is Rietveld 408576698