Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: src/runtime/runtime-generator.cc

Issue 1923253002: [generators] Create the fixed array holding the registers only once. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-debug.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/factory.h" 8 #include "src/factory.h"
9 #include "src/frames-inl.h" 9 #include "src/frames-inl.h"
10 #include "src/objects-inl.h" 10 #include "src/objects-inl.h"
11 11
12 namespace v8 { 12 namespace v8 {
13 namespace internal { 13 namespace internal {
14 14
15 RUNTIME_FUNCTION(Runtime_CreateJSGeneratorObject) { 15 RUNTIME_FUNCTION(Runtime_CreateJSGeneratorObject) {
16 HandleScope scope(isolate); 16 HandleScope scope(isolate);
17 DCHECK(args.length() == 2); 17 DCHECK(args.length() == 2);
18 CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 0); 18 CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 0);
19 CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 1); 19 CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 1);
20 RUNTIME_ASSERT(function->shared()->is_generator()); 20 RUNTIME_ASSERT(function->shared()->is_generator());
21 21
22 Handle<FixedArray> operand_stack;
23 if (FLAG_ignition && FLAG_ignition_generators) {
24 int size = function->shared()->bytecode_array()->register_count();
25 operand_stack = isolate->factory()->NewFixedArray(size);
26 } else {
27 DCHECK(!function->shared()->HasBytecodeArray());
28 operand_stack = handle(isolate->heap()->empty_fixed_array());
29 }
30
22 Handle<JSGeneratorObject> generator = 31 Handle<JSGeneratorObject> generator =
23 isolate->factory()->NewJSGeneratorObject(function); 32 isolate->factory()->NewJSGeneratorObject(function);
24 generator->set_function(*function); 33 generator->set_function(*function);
25 generator->set_context(isolate->context()); 34 generator->set_context(isolate->context());
26 generator->set_receiver(*receiver); 35 generator->set_receiver(*receiver);
27 generator->set_operand_stack(isolate->heap()->empty_fixed_array()); 36 generator->set_operand_stack(*operand_stack);
28 generator->set_continuation(JSGeneratorObject::kGeneratorExecuting); 37 generator->set_continuation(JSGeneratorObject::kGeneratorExecuting);
29 return *generator; 38 return *generator;
30 } 39 }
31 40
32 41
33 RUNTIME_FUNCTION(Runtime_SuspendJSGeneratorObject) { 42 RUNTIME_FUNCTION(Runtime_SuspendJSGeneratorObject) {
34 HandleScope handle_scope(isolate); 43 HandleScope handle_scope(isolate);
35 DCHECK(args.length() == 1); 44 DCHECK(args.length() == 1);
36 CONVERT_ARG_HANDLE_CHECKED(JSGeneratorObject, generator_object, 0); 45 CONVERT_ARG_HANDLE_CHECKED(JSGeneratorObject, generator_object, 0);
37 46
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 int offset = generator->continuation(); 149 int offset = generator->continuation();
141 RUNTIME_ASSERT(0 <= offset && offset < code->instruction_size()); 150 RUNTIME_ASSERT(0 <= offset && offset < code->instruction_size());
142 return Smi::FromInt(code->SourcePosition(offset)); 151 return Smi::FromInt(code->SourcePosition(offset));
143 } 152 }
144 153
145 return isolate->heap()->undefined_value(); 154 return isolate->heap()->undefined_value();
146 } 155 }
147 156
148 } // namespace internal 157 } // namespace internal
149 } // namespace v8 158 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects-debug.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698