Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3211)

Unified Diff: chrome/browser/ui/translate/translate_bubble_view_state_transition.cc

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor changes in comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/translate/translate_bubble_view_state_transition.cc
diff --git a/chrome/browser/ui/translate/translate_bubble_view_state_transition.cc b/chrome/browser/ui/translate/translate_bubble_view_state_transition.cc
index 4b0689e4adf0875e64f49d4cc2f102b3e852149a..cde6058d21c03a729435f7e47034cf542d59f627 100644
--- a/chrome/browser/ui/translate/translate_bubble_view_state_transition.cc
+++ b/chrome/browser/ui/translate/translate_bubble_view_state_transition.cc
@@ -7,24 +7,9 @@
#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
-namespace {
-
-enum TranslateBubbleUiEvent {
- // Bubble enters the options state.
- SET_STATE_OPTIONS = 1,
-
- // Bubble leaves the options state.
- LEAVE_STATE_OPTIONS = 2,
-
- TRANSLATE_BUBBLE_UI_EVENT_MAX
-};
-
-} // namespace
-
TranslateBubbleViewStateTransition::TranslateBubbleViewStateTransition(
TranslateBubbleModel::ViewState view_state)
- : view_state_(view_state),
- view_state_before_advanced_view_(view_state) {
+ : view_state_(view_state), view_state_before_advanced_view_(view_state) {
// The initial view type must not be 'Advanced'.
DCHECK_NE(TranslateBubbleModel::VIEW_STATE_ADVANCED, view_state_);
}
@@ -35,13 +20,15 @@ void TranslateBubbleViewStateTransition::SetViewState(
if (view_state != TranslateBubbleModel::VIEW_STATE_ADVANCED)
view_state_before_advanced_view_ = view_state;
else
- UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent", SET_STATE_OPTIONS,
- TRANSLATE_BUBBLE_UI_EVENT_MAX);
+ UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent",
+ translate::SET_STATE_OPTIONS,
+ translate::TRANSLATE_BUBBLE_UI_EVENT_MAX);
}
void TranslateBubbleViewStateTransition::GoBackFromAdvanced() {
DCHECK(view_state_ == TranslateBubbleModel::VIEW_STATE_ADVANCED);
- UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent", LEAVE_STATE_OPTIONS,
- TRANSLATE_BUBBLE_UI_EVENT_MAX);
+ UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent",
+ translate::LEAVE_STATE_OPTIONS,
+ translate::TRANSLATE_BUBBLE_UI_EVENT_MAX);
SetViewState(view_state_before_advanced_view_);
}

Powered by Google App Engine
This is Rietveld 408576698