Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: chrome/browser/translate/chrome_translate_client.cc

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add 200 icon png. remove unnecessary include in .cc file, remove unnecessary reset and remove expli… Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/chrome_translate_client.cc
diff --git a/chrome/browser/translate/chrome_translate_client.cc b/chrome/browser/translate/chrome_translate_client.cc
index ce32fe0cfdbbcd393e6b4de9c39e5ac61e8e10e4..75c29e73ee4dd7be78d71385d7a52303ae6f4a13 100644
--- a/chrome/browser/translate/chrome_translate_client.cc
+++ b/chrome/browser/translate/chrome_translate_client.cc
@@ -190,12 +190,8 @@ void ChromeTranslateClient::ShowTranslateUI(
step != translate::TRANSLATE_STEP_BEFORE_TRANSLATE,
translate_manager_->GetWeakPtr(),
InfoBarService::FromWebContents(web_contents()),
- web_contents()->GetBrowserContext()->IsOffTheRecord(),
- step,
- source_language,
- target_language,
- error_type,
- triggered_from_menu);
+ web_contents()->GetBrowserContext()->IsOffTheRecord(), step,
+ source_language, target_language, error_type, triggered_from_menu);
return;
}
#endif
@@ -204,8 +200,10 @@ void ChromeTranslateClient::ShowTranslateUI(
if (step == translate::TRANSLATE_STEP_BEFORE_TRANSLATE) {
// TODO(droger): Move this logic out of UI code.
GetLanguageState().SetTranslateEnabled(true);
- if (!GetLanguageState().HasLanguageChanged())
+ if (!base::FeatureList::IsEnabled(translate::kTranslateUI2016Q2) &&
msw 2016/05/03 22:33:34 Why does this only bail for the old UI? Maybe add
ftang 2016/05/03 23:55:41 The problem is currently it stop offer translate i
msw 2016/05/04 00:19:20 I don't understand why this is okay for the new UI
+ !GetLanguageState().HasLanguageChanged()) {
return;
+ }
if (!triggered_from_menu) {
if (web_contents()->GetBrowserContext()->IsOffTheRecord())
@@ -268,8 +266,8 @@ void ChromeTranslateClient::ShowReportLanguageDetectionErrorUI(
return;
}
- chrome::AddSelectedTabWithURL(
- browser, report_url, ui::PAGE_TRANSITION_AUTO_BOOKMARK);
+ chrome::AddSelectedTabWithURL(browser, report_url,
+ ui::PAGE_TRANSITION_AUTO_BOOKMARK);
#endif // defined(OS_ANDROID)
}
@@ -341,8 +339,8 @@ void ChromeTranslateClient::ShowBubble(
return;
}
- TranslateBubbleFactory::Show(
- browser->window(), web_contents(), step, error_type);
+ TranslateBubbleFactory::Show(browser->window(), web_contents(), step,
+ error_type);
#else
NOTREACHED();
#endif

Powered by Google App Engine
This is Rietveld 408576698