chrome/browser/ui/translate/translate_bubble_model.h - Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/translate/translate_bubble_model.h

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change according to msw review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/translate/chrome_translate_client.cc ('k') | chrome/browser/ui/translate/translate_bubble_model_impl.h » ('j') | chrome/browser/ui/translate/translate_bubble_view_state_transition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/translate/translate_bubble_model.h

diff --git a/chrome/browser/ui/translate/translate_bubble_model.h b/chrome/browser/ui/translate/translate_bubble_model.h

index 259b570780a7f74dabd0733b09a9cb45dceab6ca..35df9aa474ac6d6b252e3afa4655f17689004f35 100644

--- a/chrome/browser/ui/translate/translate_bubble_model.h

+++ b/chrome/browser/ui/translate/translate_bubble_model.h

@@ -82,6 +82,9 @@ class TranslateBubbleModel {

// translated into the current target language automatically.

virtual bool ShouldAlwaysTranslate() const = 0;

+ // Returns true if the Always Translate should be Checked by default.

msw 2016/04/29 23:43:40 nit: 'Translate button should' and do not capitali

ftang 2016/04/30 01:24:50 Done.

+ virtual bool ShouldAlwaysTranslateCheckedByDefault() const = 0;

msw 2016/04/29 23:43:40 nit: TranslateBeChecked

ftang 2016/04/30 01:24:49 Done.

// Sets the value if the webpage in the current original language should be

// translated into the current target language automatically.

virtual void SetAlwaysTranslate(bool value) = 0;