Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5579)

Unified Diff: chrome/browser/ui/translate/translate_bubble_view_state_transition.h

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix namespace in .h and other minor review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/translate/translate_bubble_view_state_transition.h
diff --git a/chrome/browser/ui/translate/translate_bubble_view_state_transition.h b/chrome/browser/ui/translate/translate_bubble_view_state_transition.h
index 383bc24cb7ad754f3125c320470585ac12c2cd5d..0f91f6bdb91f17e811cab921c2854c26cf1f2165 100644
--- a/chrome/browser/ui/translate/translate_bubble_view_state_transition.h
+++ b/chrome/browser/ui/translate/translate_bubble_view_state_transition.h
@@ -8,6 +8,63 @@
#include "base/macros.h"
#include "chrome/browser/ui/translate/translate_bubble_model.h"
+namespace translate {
msw 2016/04/29 20:00:00 nit: add a blank line between the namespace and th
ftang 2016/04/29 22:37:00 Done.
+enum TranslateBubbleUiEvent {
+ // Bubble enters the options state.
msw 2016/04/29 20:00:00 Give a more descriptive comment, maybe "The bubble
ftang 2016/04/29 22:37:00 Done.
+ SET_STATE_OPTIONS = 1,
msw 2016/04/29 20:00:00 Why do you give explicit values to the enums? Remo
+
+ // Bubble leaves the options state.
+ LEAVE_STATE_OPTIONS = 2,
+
+ // User click the advanced link
msw 2016/04/29 20:00:00 Add trailing periods on this comment and others be
msw 2016/04/29 20:00:00 It'd be nice if you used the same subject and tens
ftang 2016/04/29 22:37:00 Done.
ftang 2016/04/29 22:37:00 Done.
+ ADVANCED_LINK_CLICKED = 3,
+
+ // User check the "always translate" checkbox
+ ALWAYS_TRANSLATE_CHECKED = 4,
+
+ // User uncheck the "always translate" checkbox
+ ALWAYS_TRANSLATE_UNCHECKED = 5,
+
+ // User select the "Nope" in option menu
+ NOPE_MENU_CLICKED = 6,
+
+ // User select the "Never translate language" in option menu
+ NEVER_TRANSLATE_LANGUAGE_MENU_CLICKED = 7,
+
+ // User select the "Never translate this site" in option menu
+ NEVER_TRANSLATE_SITE_MENU_CLICKED = 8,
+
+ // User click "Translate" button
+ TRANSLATE_BUTTON_CLICKED = 9,
+
+ // User click the "Done" button
+ DONE_BUTTON_CLICKED = 10,
+
+ // User click the "Cancel" button
+ CANCEL_BUTTON_CLICKED = 11,
+
+ // User click the "Closed" [X] button
msw 2016/04/29 20:00:00 nit: s/Closed/Close/ and s/[X]/(x)/
+ CLOSE_BUTTON_CLICKED = 12,
+
+ // User click the "Try Again" button
+ TRY_AGAIN_BUTTON_CLICKED = 13,
+
+ // User click the "Show Original" button
+ SHOW_ORIGINAL_BUTTON_CLICKED = 14,
+
+ // User click the "Setting" link
+ SETTING_LINK_CLICKED = 15,
+
+ // User change the "Source language"
+ SOURCE_LANGUAGE_MENU_CLICKED = 16,
+
+ // User change the "Target language"
+ TARGET_LANGUAGE_MENU_CLICKED = 17 ,
msw 2016/04/29 20:00:00 nit: remove the space before the comma.
+
+ TRANSLATE_BUBBLE_UI_EVENT_MAX
+};
+} // namespace translate
+
// The class which manages the transition of the view state of the Translate
// bubble.
class TranslateBubbleViewStateTransition {

Powered by Google App Engine
This is Rietveld 408576698